From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754051Ab0AHTLW (ORCPT ); Fri, 8 Jan 2010 14:11:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753928Ab0AHTLV (ORCPT ); Fri, 8 Jan 2010 14:11:21 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:54328 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753910Ab0AHTLU (ORCPT ); Fri, 8 Jan 2010 14:11:20 -0500 To: Yinghai Lu Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , Jesse Brandeburg , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] x86: update nr_irqs according cpu num References: <1262951595-1729-1-git-send-email-yinghai@kernel.org> <1262951595-1729-5-git-send-email-yinghai@kernel.org> From: ebiederm@xmission.com (Eric W. Biederman) Date: Fri, 08 Jan 2010 11:11:14 -0800 In-Reply-To: <1262951595-1729-5-git-send-email-yinghai@kernel.org> (Yinghai Lu's message of "Fri\, 08 Jan 2010 03\:53\:15 -0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=in01.mta.xmission.com;;;ip=76.21.114.89;;;frm=ebiederm@xmission.com;;;spf=neutral X-SA-Exim-Connect-IP: 76.21.114.89 X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Scanned: No (on in01.mta.xmission.com); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yinghai Lu writes: > that is max number on run time. Ouch! Unless I misread this code this will leave nr_irqs at NR_IRQS_LEGACY. aka 16. Let's do something stupid and simple. nr_irqs = nr_cpus_ids * 256; /* Semi-arbitrary number */ Ideally we would set "nr_irqs = 0x7fffffff;" but we have just enough places using nr_irqs that I think those loops would get painful if we were to do that. Eric