All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, shemminger@vyatta.com,
	brian.haley@hp.com, lorenzo@google.com,
	herbert@gondor.hengli.com.au
Subject: Re: [PATCH] ipv6: Revert 'administrative down' address handling changes.
Date: Tue, 25 Jan 2011 10:55:31 -0800	[thread overview]
Message-ID: <m1ei803ja4.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <m1zkqp2woo.fsf@fess.ebiederm.org> (Eric W. Biederman's message of "Tue, 25 Jan 2011 00:51:19 -0800")

ebiederm@xmission.com (Eric W. Biederman) writes:

> David Miller <davem@davemloft.net> writes:
>
>> From: David Miller <davem@davemloft.net>
>> Date: Sun, 23 Jan 2011 23:41:01 -0800 (PST)
>>
>>> Eric B. and co., please do some testing to make sure all of your
>>> disable_ipv6 cases are functioning properly with this applied.
>>
>> Ping?
>
> In progress.  I had to make a small change to your patch to get it
> to apply against 2.6.37.  neigh_ifdown has not been removed from the
> beginning of addrconf_ifdown there.  The piece that was failing for
> me is not failing now so, so far so good.
>
> It was reported that in 2.6.37 there was a new regression that
> 1connecting to ::1 when ipv6 was disabled would not fail immediately but
> would have to wait a while.  With your patch applied I am not seeing
> that behavior either.
>
> Tomorrow I should know if I see any weird side effects with your patch,
> after my regression tests for everything else have finished running.

I have to admit I am seeing weird side effects.  A test that was
mysteriously failing because it could not create a vlan on top of a tap
device has started working again ;)

So this change is looking really good for me.

I have to track through some additional failures that I think are test
bugs, but it looks like I might finally have 2.6.37 in a shape where I
can use it.

Eric

  reply	other threads:[~2011-01-25 18:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24  7:41 [PATCH] ipv6: Revert 'administrative down' address handling changes David Miller
2011-01-25  7:38 ` David Miller
2011-01-25  8:51   ` Eric W. Biederman
2011-01-25 18:55     ` Eric W. Biederman [this message]
2011-01-25 20:49       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ei803ja4.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=brian.haley@hp.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=lorenzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.