From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1134C433ED for ; Wed, 5 May 2021 14:13:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A60D3613BC for ; Wed, 5 May 2021 14:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232171AbhEEOOA (ORCPT ); Wed, 5 May 2021 10:14:00 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:43334 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232596AbhEEONl (ORCPT ); Wed, 5 May 2021 10:13:41 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1leIGa-00CGlJ-DX; Wed, 05 May 2021 08:12:44 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=fess.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1leIGX-002GvZ-Te; Wed, 05 May 2021 08:12:43 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Marco Elver Cc: Arnd Bergmann , Florian Weimer , "David S. Miller" , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Peter Collingbourne , Dmitry Vyukov , Alexander Potapenko , sparclinux , linux-arch , Linux Kernel Mailing List , Linux API , kasan-dev References: Date: Wed, 05 May 2021 09:12:38 -0500 In-Reply-To: (Marco Elver's message of "Wed, 5 May 2021 00:05:00 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1leIGX-002GvZ-Te;;;mid=;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19By7EuCGlSC+Hrh/+dmLFpw1rmZv8aoeM= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH v3 00/12] signal: sort out si_trapno and si_perf X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Marco Elver writes: > On Tue, 4 May 2021 at 23:13, Eric W. Biederman wrote: >> >> This set of changes sorts out the ABI issues with SIGTRAP TRAP_PERF, and >> hopefully will can get merged before any userspace code starts using the >> new ABI. >> >> The big ideas are: >> - Placing the asserts first to prevent unexpected ABI changes >> - si_trapno becomming ordinary fault subfield. >> - struct signalfd_siginfo is almost full >> >> This set of changes starts out with Marco's static_assert changes and >> additional one of my own that enforces the fact that the alignment of >> siginfo_t is also part of the ABI. Together these build time >> checks verify there are no unexpected ABI changes in the changes >> that follow. >> >> The field si_trapno is changed to become an ordinary extension of the >> _sigfault member of siginfo. >> >> The code is refactored a bit and then si_perf_type is added along side >> si_perf_data in the _perf subfield of _sigfault of siginfo_t. >> >> Finally the signalfd_siginfo fields are removed as they appear to be >> filling up the structure without userspace actually being able to use >> them. >> >> v2: https://lkml.kernel.org/r/m14kfjh8et.fsf_-_@fess.ebiederm.org >> v1: https://lkml.kernel.org/r/m1zgxfs7zq.fsf_-_@fess.ebiederm.org >> >> Eric W. Biederman (9): >> signal: Verify the alignment and size of siginfo_t >> siginfo: Move si_trapno inside the union inside _si_fault >> signal: Implement SIL_FAULT_TRAPNO >> signal: Use dedicated helpers to send signals with si_trapno set >> signal: Remove __ARCH_SI_TRAPNO >> signal: Rename SIL_PERF_EVENT SIL_FAULT_PERF_EVENT for consistency >> signal: Factor force_sig_perf out of perf_sigtrap >> signal: Deliver all of the siginfo perf data in _perf >> signalfd: Remove SIL_FAULT_PERF_EVENT fields from signalfd_siginfo >> >> Marco Elver (3): >> sparc64: Add compile-time asserts for siginfo_t offsets >> arm: Add compile-time asserts for siginfo_t offsets >> arm64: Add compile-time asserts for siginfo_t offsets > > I can't seem to see the rest of them in my inbox. LKML also is missing > them: https://lore.kernel.org/linux-api/m1tuni8ano.fsf_-_@fess.ebiederm.org/ > > Something must have swallowed them. Could you resend? > I'll then test in the morning. They got stuck going out you should see them any time now. Sorry about that. Eric