All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: caiqian@redhat.com
Cc: Simon Horman <horms@verge.net.au>,
	Kexec Mailing List <kexec@lists.infradead.org>
Subject: Re: [GIT PULL] Please pull x86 biarch crashdump support and misc devel
Date: Fri, 10 Sep 2010 22:47:54 -0700	[thread overview]
Message-ID: <m1pqwk4yr9.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <m1vd6c519r.fsf@fess.ebiederm.org> (Eric W. Biederman's message of "Fri, 10 Sep 2010 21:53:36 -0700")

ebiederm@xmission.com (Eric W. Biederman) writes:

> caiqian@redhat.com writes:
>
>>> I have fixed the wrong variable problem and I also spotted another
>>> architecture test in crashdump-x86e that would only work on i386, and
>>> fixed that.
>>> 
>>> The new version is up at:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/kexec-tools-devel.git
>> # /sbin/kexec -p '--command-line=ro root=/dev/mapper/vg_intels3e3601-lv_root rd_LVM_LV=vg_intels3e3601/lv_root rd_LVM_LV=vg_intels3e3601/lv_swap rd_NO_LUKS rd_NO_MD rd_NO_DM LANG=en_US.UTF-8 SYSFONT=latarcyrheb-sun16 KEYBOARDTYPE=pc KEYTABLE=us console=ttyS0,115200n81 irqpoll maxcpus=1 reset_devices cgroup_disable=memory sysrq_always_enabled ' --initrd=/boot/initrd-2.6.32-71.el6.bz623007.x86_64kdump.img /boot/vmlinuz-2.6.32-71.el6.bz623007.x86_64
>> Segmentation fault (core dumped)
>
> Thanks.  Wow I am out of it.  It appears that I was assuming elf_info
> was zero initialized but taking no steps to make it that way, and
> someone elf_info.get_note_info took the value of one.
>
> I have added a memset and pushed that version of my code.
> I also took a moment and made certain that kexec -p at least works.
>
> I am surprised this bug didn't show up in my 32bit testing, *ugh*.
>
> So if you are brave and want to test there is a slim chance my new
> version of kexec will actually work on x86_64 now.

Ok.  This time I really have tested my new version of kexec on x86_64
and it is working.  At least enough to get me a crashdump that I
can read with vmcore-dmesg.  So unless I think my horrible of trivial
mistakes is at an end.

I would love to hear a test result from someone else,
and I apologize to everyone for messing up.

Eric

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2010-09-11  5:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1780019082.729911284179131961.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-11  4:25 ` [GIT PULL] Please pull x86 biarch crashdump support and misc devel caiqian
2010-09-11  4:53   ` Eric W. Biederman
2010-09-11  5:47     ` Eric W. Biederman [this message]
2010-09-11 13:48       ` CAI Qian
     [not found] <575742837.695351284137649163.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-10 16:54 ` caiqian
2010-09-10 19:15   ` Eric W. Biederman
2010-09-10 19:19   ` Eric W. Biederman
2010-09-11  1:40     ` CAI Qian
2010-09-11  2:05       ` CAI Qian
2010-09-11  4:00         ` Eric W. Biederman
     [not found] <453826608.695091284137315385.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-10 16:49 ` caiqian
     [not found] <822803231.671471284126247290.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-09-10 13:45 ` caiqian
2010-09-08 19:44 Eric W. Biederman
2010-09-08 19:51 ` Eric W. Biederman
2010-09-09  1:35 ` Simon Horman
2010-09-09  1:46   ` Eric W. Biederman
2010-09-09  2:42     ` Simon Horman
2010-09-09  5:59       ` Eric W. Biederman
2010-09-09  8:14         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1pqwk4yr9.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=caiqian@redhat.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.