From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F76AC433DB for ; Tue, 16 Mar 2021 01:19:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CBB464F7B for ; Tue, 16 Mar 2021 01:19:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229540AbhCPBTL (ORCPT ); Mon, 15 Mar 2021 21:19:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232746AbhCPBTE (ORCPT ); Mon, 15 Mar 2021 21:19:04 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F40BC06174A for ; Mon, 15 Mar 2021 18:19:04 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id o3so3054409pfh.11 for ; Mon, 15 Mar 2021 18:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=nF5FcRFNraHBE0OVbfh0No934vQd9+JmS7SJMUyo7vE=; b=eZOnAu04HSa59S4UF1+Kk7hMmfflr113fVEJ5As9cjN+x5ZaoDllGS+T8pCcIevKDl 7UUFcODdF6mU8U6rPRfASG8v1uHGL8xESOS78HDKcDJkNp54ezC4S3A1CqZsafZpBlwS isEU2r1Fh2ivih9pKoilDTOFj9EuPK8zdOgVAxABEaX0bsZiPuMwzbHJUbMBmTNjp5wW NMV2MPdLDTx+iwGuw+gHasD2hYDyI7BC4xNIIIWSRNfUbbQ/4c7mqrLXnw0yvSn3wAQB hY12SnRidSkRLVYf0HU4Q9mwXLHIzKfvJ1XjUPtZ73ManJaiAt7oYTKtJlrRHNYgKeCF y87w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=nF5FcRFNraHBE0OVbfh0No934vQd9+JmS7SJMUyo7vE=; b=GCyfeADtdkq0Pdl2gJ6i5UxAILKc88X70KPeFsSk6hLNLy2bMOVxni2+hKY4W+CWay rbWAwTT2STew5fuhQMRU+86YUiG33GcNEHVuLwhUGD9WpqbnON/WZcvJzhmfowjEUPvf znZ9ePOA4Ojn6dD3vqCdh8B1KyCAWDXC4UEG17c5FVEDoojhFuNKS7bMkdNQPDQNyhtH L7KPt1+aLBg57mpujhcAg1mVHszndunCl/GJ+/vsoj+ItrUD8KJHkGB7ehXnwV11HKuv GR9sKOU4yO3jnOXyzz9ygxxwVdmR5lAV2N/PSJv5MUdrDRoU3UCLbJWT0ClSWv/of8mS iUIw== X-Gm-Message-State: AOAM532N8oEyxOgmCkDAtyTE4dq2BtbNzqWb7nTeRogZJfBmpRSfANT5 Ifcuu1h91pOx+X8o+mT58sc= X-Google-Smtp-Source: ABdhPJyTjyu6WjTOSb86t+HiygIV5p0tXOZhhJV+z6FY6G6mTAqIRdNFI8jpbN173yTtP9Qw992v3g== X-Received: by 2002:a62:7ecc:0:b029:1ee:f61b:a63f with SMTP id z195-20020a627ecc0000b02901eef61ba63fmr12471631pfc.57.1615857543621; Mon, 15 Mar 2021 18:19:03 -0700 (PDT) Received: from sun.local.gmail.com (219x123x138x129.ap219.ftth.ucom.ne.jp. [219.123.138.129]) by smtp.gmail.com with ESMTPSA id e11sm14629369pfm.24.2021.03.15.18.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 18:19:03 -0700 (PDT) Date: Tue, 16 Mar 2021 10:19:02 +0900 Message-ID: From: Hajime Tazaki To: johannes@sipsolutions.net Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com Subject: Re: [RFC v8 19/20] um: lkl: add block device support of UML In-Reply-To: <2b649bc5165c7ff4547abd72f7e03e7491980138.camel@sipsolutions.net> References: <2b649bc5165c7ff4547abd72f7e03e7491980138.camel@sipsolutions.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.1 Mule/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Mon, 15 Mar 2021 05:37:40 +0900, Johannes Berg wrote: >=20 > On Wed, 2021-01-20 at 11:27 +0900, Hajime Tazaki wrote: > >=20 > > diff --git a/arch/um/Kconfig b/arch/um/Kconfig > > index 24c6596260de..5fb6a852d058 100644 > > --- a/arch/um/Kconfig > > +++ b/arch/um/Kconfig > > @@ -29,6 +29,10 @@ config UMMODE_LIB > > =A0 select UACCESS_MEMCPY > > =A0 select ARCH_THREAD_STACK_ALLOCATOR > > =A0 select ARCH_HAS_SYSCALL_WRAPPER > > + select VFAT_FS > > + select NLS_CODEPAGE_437 > > + select NLS_ISO8859_1 > > + select BTRFS_FS >=20 > That doesn't really seem to make sense - the sample might need it, but > generally LKL doesn't/shouldn't? I'm trying to understand your comment; Do you mean that enabling those options in Kconfig doesn't make sense ? and if you mean the sample as sample code, is the added test case (e.g., tools/testing/selftests/um/disk.c, which is included in the same patch) for this purpose ? -- HAjime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLyMS-00HB7C-U5 for linux-um@lists.infradead.org; Tue, 16 Mar 2021 01:19:07 +0000 Received: by mail-pf1-x42d.google.com with SMTP id e26so7711745pfd.9 for ; Mon, 15 Mar 2021 18:19:04 -0700 (PDT) Date: Tue, 16 Mar 2021 10:19:02 +0900 Message-ID: From: Hajime Tazaki Subject: Re: [RFC v8 19/20] um: lkl: add block device support of UML In-Reply-To: <2b649bc5165c7ff4547abd72f7e03e7491980138.camel@sipsolutions.net> References: <2b649bc5165c7ff4547abd72f7e03e7491980138.camel@sipsolutions.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: johannes@sipsolutions.net Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com On Mon, 15 Mar 2021 05:37:40 +0900, Johannes Berg wrote: > = > On Wed, 2021-01-20 at 11:27 +0900, Hajime Tazaki wrote: > > = > > diff --git a/arch/um/Kconfig b/arch/um/Kconfig > > index 24c6596260de..5fb6a852d058 100644 > > --- a/arch/um/Kconfig > > +++ b/arch/um/Kconfig > > @@ -29,6 +29,10 @@ config UMMODE_LIB > > =A0 select UACCESS_MEMCPY > > =A0 select ARCH_THREAD_STACK_ALLOCATOR > > =A0 select ARCH_HAS_SYSCALL_WRAPPER > > + select VFAT_FS > > + select NLS_CODEPAGE_437 > > + select NLS_ISO8859_1 > > + select BTRFS_FS > = > That doesn't really seem to make sense - the sample might need it, but > generally LKL doesn't/shouldn't? I'm trying to understand your comment; Do you mean that enabling those options in Kconfig doesn't make sense ? and if you mean the sample as sample code, is the added test case (e.g., tools/testing/selftests/um/disk.c, which is included in the same patch) for this purpose ? -- HAjime _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um