From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933921AbdCJVTF (ORCPT ); Fri, 10 Mar 2017 16:19:05 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:35186 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932991AbdCJVSz (ORCPT ); Fri, 10 Mar 2017 16:18:55 -0500 From: Kevin Hilman To: Dave Gerlach Cc: Ulf Hansson , "Rafael J. Wysocki" , Santosh Shilimkar , Rob Herring , , , , , Nishanth Menon , Keerthy , Russell King , Tero Kristo , Sudeep Holla Subject: Re: [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells Organization: BayLibre References: <1488882154-21485-1-git-send-email-d-gerlach@ti.com> <1488882154-21485-3-git-send-email-d-gerlach@ti.com> Date: Fri, 10 Mar 2017 13:18:47 -0800 In-Reply-To: <1488882154-21485-3-git-send-email-d-gerlach@ti.com> (Dave Gerlach's message of "Tue, 7 Mar 2017 04:22:31 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dave Gerlach writes: > There is no reason that a platform genpd driver registered using > of_genpd_add_provider_simple needs to be constrained to having no cells > in the "power-domains" phandle. Currently the genpd framework will fail > if any arguments are passed with for a simple provider but the framework > does not actually care, so remove the check for phandle argument count. > > This will allow greater flexibility for genpd providers to use their own > arguments that are passed in the phandle and interpret them however they > see fit. > > Signed-off-by: Dave Gerlach Acked-by: Kevin Hilman > --- > v3->v4: > Drop ti,sci-id device property and instead describe using phandle cell > for id. > > drivers/base/power/domain.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index e697dec9d25b..8e0550c27394 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1622,8 +1622,6 @@ static struct generic_pm_domain *genpd_xlate_simple( > struct of_phandle_args *genpdspec, > void *data) > { > - if (genpdspec->args_count != 0) > - return ERR_PTR(-EINVAL); > return data; > } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells Date: Fri, 10 Mar 2017 13:18:47 -0800 Message-ID: References: <1488882154-21485-1-git-send-email-d-gerlach@ti.com> <1488882154-21485-3-git-send-email-d-gerlach@ti.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1488882154-21485-3-git-send-email-d-gerlach@ti.com> (Dave Gerlach's message of "Tue, 7 Mar 2017 04:22:31 -0600") Sender: linux-pm-owner@vger.kernel.org To: Dave Gerlach Cc: Ulf Hansson , "Rafael J. Wysocki" , Santosh Shilimkar , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Nishanth Menon , Keerthy , Russell King , Tero Kristo , Sudeep Holla List-Id: devicetree@vger.kernel.org Dave Gerlach writes: > There is no reason that a platform genpd driver registered using > of_genpd_add_provider_simple needs to be constrained to having no cells > in the "power-domains" phandle. Currently the genpd framework will fail > if any arguments are passed with for a simple provider but the framework > does not actually care, so remove the check for phandle argument count. > > This will allow greater flexibility for genpd providers to use their own > arguments that are passed in the phandle and interpret them however they > see fit. > > Signed-off-by: Dave Gerlach Acked-by: Kevin Hilman > --- > v3->v4: > Drop ti,sci-id device property and instead describe using phandle cell > for id. > > drivers/base/power/domain.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index e697dec9d25b..8e0550c27394 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1622,8 +1622,6 @@ static struct generic_pm_domain *genpd_xlate_simple( > struct of_phandle_args *genpdspec, > void *data) > { > - if (genpdspec->args_count != 0) > - return ERR_PTR(-EINVAL); > return data; > } From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Fri, 10 Mar 2017 13:18:47 -0800 Subject: [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells In-Reply-To: <1488882154-21485-3-git-send-email-d-gerlach@ti.com> (Dave Gerlach's message of "Tue, 7 Mar 2017 04:22:31 -0600") References: <1488882154-21485-1-git-send-email-d-gerlach@ti.com> <1488882154-21485-3-git-send-email-d-gerlach@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dave Gerlach writes: > There is no reason that a platform genpd driver registered using > of_genpd_add_provider_simple needs to be constrained to having no cells > in the "power-domains" phandle. Currently the genpd framework will fail > if any arguments are passed with for a simple provider but the framework > does not actually care, so remove the check for phandle argument count. > > This will allow greater flexibility for genpd providers to use their own > arguments that are passed in the phandle and interpret them however they > see fit. > > Signed-off-by: Dave Gerlach Acked-by: Kevin Hilman > --- > v3->v4: > Drop ti,sci-id device property and instead describe using phandle cell > for id. > > drivers/base/power/domain.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index e697dec9d25b..8e0550c27394 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1622,8 +1622,6 @@ static struct generic_pm_domain *genpd_xlate_simple( > struct of_phandle_args *genpdspec, > void *data) > { > - if (genpdspec->args_count != 0) > - return ERR_PTR(-EINVAL); > return data; > }