From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Creekmore Subject: Re: [PATCH v4 5/5] sched: Use the auto-generated list of schedulers Date: Sat, 09 Jan 2016 16:43:47 -0600 Message-ID: References: <1452288166-43501-1-git-send-email-jonathan.creekmore@gmail.com> <1452288166-43501-6-git-send-email-jonathan.creekmore@gmail.com> <56915166.10907@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aI2Eh-00046F-3o for xen-devel@lists.xenproject.org; Sat, 09 Jan 2016 22:43:51 +0000 Received: by mail-yk0-f195.google.com with SMTP id a85so25434236ykb.2 for ; Sat, 09 Jan 2016 14:43:49 -0800 (PST) In-reply-to: <56915166.10907@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: George Dunlap , Jonathan Creekmore , Dario Faggioli , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org Andrew Cooper writes: > On 08/01/16 21:22, Jonathan Creekmore wrote: >> diff --git a/xen/common/schedule.c b/xen/common/schedule.c >> index 2f98a48..91e53c1 100644 >> --- a/xen/common/schedule.c >> +++ b/xen/common/schedule.c >> @@ -64,20 +64,10 @@ static void poll_timer_fn(void *data); >> DEFINE_PER_CPU(struct schedule_data, schedule_data); >> DEFINE_PER_CPU(struct scheduler *, scheduler); >> >> -static const struct scheduler *schedulers[] = { >> -#ifdef CONFIG_SCHED_CREDIT >> - &sched_credit_def, >> -#endif >> -#ifdef CONFIG_SCHED_CREDIT2 >> - &sched_credit2_def, >> -#endif >> -#ifdef CONFIG_SCHED_ARINC653 >> - &sched_arinc653_def, >> -#endif >> -#ifdef CONFIG_SCHED_RTDS >> - &sched_rtds_def, >> -#endif >> -}; >> +extern const struct scheduler *__start_schedulers_array[], *__end_schedulers_array[]; >> +extern const size_t schedulers_array_size; > > Is schedulers_array_size declared or used anywhere? I can't see any use. You are right. That is a holdover from a previous version. I will drop that.