From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4747C433E0 for ; Tue, 16 Mar 2021 01:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C93764F94 for ; Tue, 16 Mar 2021 01:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232223AbhCPBSI (ORCPT ); Mon, 15 Mar 2021 21:18:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231376AbhCPBSB (ORCPT ); Mon, 15 Mar 2021 21:18:01 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D423C06174A for ; Mon, 15 Mar 2021 18:18:01 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id x21so6410907pfa.3 for ; Mon, 15 Mar 2021 18:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version; bh=qhcuYdoOMtV0w4cVzRWN1fajWGcUJ8HbjTsCeMUOnIM=; b=ae6bZCdsqozefryLiEyTDBBld41fLCIpwH1QBXqZ6DSjKtW9mvE0Ge8nRgCgGlBtBJ 2OYfY3r7s2hqCZLjiRTAV24k3WYWSIqto5uxZORtxbObSPzG2ZMovDb3keGctARCS/nd KYTzMZEZwWoAvmj+VK7yAN08raZKC6SGRp1SIEH6R2dBrvwFCD+NXEEUgzlUDl6+zyHf m77+n6CEhQ0BglbnX/mMVc9XHNwKbLL/3Zk1QtFIOzePQDIixJO0GYJxvMmD8UVtVkMe LEOJxwJypz5dGP6ps3hjUTOWIIzTJyPoEo12A6Lud/5XunZCTNpqI73w4dIUogeCQc1u WW7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:user-agent:mime-version; bh=qhcuYdoOMtV0w4cVzRWN1fajWGcUJ8HbjTsCeMUOnIM=; b=pPa1uSJwPPh6ju6b9Ow3XHgyhLT04hzkOmQRtxaGu7JWVsOh64h0aOTJ2oVBc45IRf PWhBk9coCodgsz0l8cUWVoKNGabnNvkVDTO+D7kgv0YRktt7geN5m/vrOOaPTO9OPfx7 uikxxaSQfVZlyOL+HsabsnL9odZpEGB7rvU4H0wREXi9tPu1FgSv+J6LI6Aekf8BGLHz 3NGWato0t8euHyn9+37Tjby/QJdcJOqO6lQpuQqaUx1NnEcXdjxnUMUiXl1gjqPd5/eA 8hLzTG2vSqh0a2m9z4D1ONcH4x2Gu7v2amFWyX0pSEZCk7DrpP4N2QWG++h9Ut8DTnee IiZg== X-Gm-Message-State: AOAM531CxeaNwtuENDMYOce+aNlUCB3PvhMnXnr7aeIfWvJQFtD0ZJqt FhYbRHRRFXcu66wevAd4r6s= X-Google-Smtp-Source: ABdhPJy7PQTqnis1Eor4iHnDhpTpOtWzi5kulryRhMkHEzb98lNTNBbpkaTUH2rrgh5Kx5N1mVzQiQ== X-Received: by 2002:a63:2c8f:: with SMTP id s137mr1557657pgs.51.1615857480769; Mon, 15 Mar 2021 18:18:00 -0700 (PDT) Received: from sun.local.gmail.com (219x123x138x129.ap219.ftth.ucom.ne.jp. [219.123.138.129]) by smtp.gmail.com with ESMTPSA id 202sm14290188pfu.46.2021.03.15.18.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 18:18:00 -0700 (PDT) Date: Tue, 16 Mar 2021 10:17:59 +0900 Message-ID: From: Hajime Tazaki To: johannes@sipsolutions.net Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com Subject: Re: [RFC v8 07/20] um: lkl: host interface In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.1 Mule/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Mon, 15 Mar 2021 01:50:27 +0900, Johannes Berg wrote: > > > > +/** > > + * struct lkl_host_operations - host operations used by the Linux kernel > > + * > > + * These operations must be provided by a host library or by the application > > + * itself. > > + * > > + */ > > +struct lkl_host_operations { > > +}; > > IIRC, in previous reviews we discussed this and you said you'd look at > just making those extern functions, instead of function pointers, since > realistically there's no use in being able to switch these at runtime. > What happened to that? Any particular reason not to? Yes, I followed your suggestion that we just use functions instead of function pointers ([17/20]). Though we won't use pointers, we still need this structure to inform userspace side (of LKL) to kernel. [19/20], block device implementation uses this. -- Hajime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLyLU-00HB2e-Rv for linux-um@lists.infradead.org; Tue, 16 Mar 2021 01:18:06 +0000 Received: by mail-pf1-x42d.google.com with SMTP id y67so7726559pfb.2 for ; Mon, 15 Mar 2021 18:18:01 -0700 (PDT) Date: Tue, 16 Mar 2021 10:17:59 +0900 Message-ID: From: Hajime Tazaki Subject: Re: [RFC v8 07/20] um: lkl: host interface In-Reply-To: References: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: johannes@sipsolutions.net Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com On Mon, 15 Mar 2021 01:50:27 +0900, Johannes Berg wrote: > > > > +/** > > + * struct lkl_host_operations - host operations used by the Linux kernel > > + * > > + * These operations must be provided by a host library or by the application > > + * itself. > > + * > > + */ > > +struct lkl_host_operations { > > +}; > > IIRC, in previous reviews we discussed this and you said you'd look at > just making those extern functions, instead of function pointers, since > realistically there's no use in being able to switch these at runtime. > What happened to that? Any particular reason not to? Yes, I followed your suggestion that we just use functions instead of function pointers ([17/20]). Though we won't use pointers, we still need this structure to inform userspace side (of LKL) to kernel. [19/20], block device implementation uses this. -- Hajime _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um