From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754196AbdCMVcb (ORCPT ); Mon, 13 Mar 2017 17:32:31 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:33142 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753308AbdCMVcX (ORCPT ); Mon, 13 Mar 2017 17:32:23 -0400 From: Kevin Hilman To: Ulf Hansson Cc: Viresh Kumar , Rafael Wysocki , Len Brown , Pavel Machek , linaro-kernel , "linux-pm\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , Vincent Guittot Subject: Re: [PATCH] PM / QOS: Remove the global notifiers Organization: BayLibre References: <8361bf69d667d7092c2b3b0ecabf147c7324ec33.1487752071.git.viresh.kumar@linaro.org> Date: Mon, 13 Mar 2017 14:32:20 -0700 In-Reply-To: (Ulf Hansson's message of "Mon, 13 Mar 2017 17:04:00 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ulf Hansson writes: > On 13 March 2017 at 17:01, Ulf Hansson wrote: >> On 22 February 2017 at 09:28, Viresh Kumar wrote: >>> They were never used in the kernel, not sure why they got merged into >>> the kernel though. Get rid of them. >> >> commit b66213cdb002b08b29603d488c451dfe25e2ca20 >> Author: Jean Pihet >> Date: Thu Aug 25 15:35:47 2011 +0200 >> >> PM QoS: Add global notification mechanism for device constraints >> >> Add a global notification chain that gets called upon changes to the >> aggregated constraint value for any device. >> The notification callbacks are passing the full constraint request data >> in order for the callees to have access to it. The current use is for the >> platform low-level code to access the target device of the constraint. >> >> Signed-off-by: Jean Pihet >> Reviewed-by: Kevin Hilman >> Signed-off-by: Rafael J. Wysocki >> >> It was a while ago since they were added, but it seems like > > Slipped on the keyboard, sorry for the noise. > > I was about to say, that it was a while ago these were added, but > still not being used. Thus let's remove them. > > Acked-by: Ulf Hansson Agreed. If we still have no users, let's remove them. Acked-by: Kevin Hilman Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] PM / QOS: Remove the global notifiers Date: Mon, 13 Mar 2017 14:32:20 -0700 Message-ID: References: <8361bf69d667d7092c2b3b0ecabf147c7324ec33.1487752071.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pg0-f48.google.com ([74.125.83.48]:35404 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753321AbdCMVcX (ORCPT ); Mon, 13 Mar 2017 17:32:23 -0400 Received: by mail-pg0-f48.google.com with SMTP id b129so70589803pgc.2 for ; Mon, 13 Mar 2017 14:32:22 -0700 (PDT) In-Reply-To: (Ulf Hansson's message of "Mon, 13 Mar 2017 17:04:00 +0100") Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Ulf Hansson Cc: Viresh Kumar , Rafael Wysocki , Len Brown , Pavel Machek , linaro-kernel , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Vincent Guittot Ulf Hansson writes: > On 13 March 2017 at 17:01, Ulf Hansson wrote: >> On 22 February 2017 at 09:28, Viresh Kumar wrote: >>> They were never used in the kernel, not sure why they got merged into >>> the kernel though. Get rid of them. >> >> commit b66213cdb002b08b29603d488c451dfe25e2ca20 >> Author: Jean Pihet >> Date: Thu Aug 25 15:35:47 2011 +0200 >> >> PM QoS: Add global notification mechanism for device constraints >> >> Add a global notification chain that gets called upon changes to the >> aggregated constraint value for any device. >> The notification callbacks are passing the full constraint request data >> in order for the callees to have access to it. The current use is for the >> platform low-level code to access the target device of the constraint. >> >> Signed-off-by: Jean Pihet >> Reviewed-by: Kevin Hilman >> Signed-off-by: Rafael J. Wysocki >> >> It was a while ago since they were added, but it seems like > > Slipped on the keyboard, sorry for the noise. > > I was about to say, that it was a while ago these were added, but > still not being used. Thus let's remove them. > > Acked-by: Ulf Hansson Agreed. If we still have no users, let's remove them. Acked-by: Kevin Hilman Kevin