From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932121Ab1G2MxK (ORCPT ); Fri, 29 Jul 2011 08:53:10 -0400 Received: from void.printf.net ([89.145.121.20]:41137 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756327Ab1G2MxI (ORCPT ); Fri, 29 Jul 2011 08:53:08 -0400 From: Chris Ball To: Will Newton Cc: James Hogan , Shashidhar Hiremath , Will Newton , Kyungmin Park , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mmc: Fixed bug in IDMAC_SET_BUFFER1_SIZE Macro in dw_mmc.c References: <1311851023-3563-1-git-send-email-shashidharh@vayavyalabs.com> <4E314562.2000001@imgtec.com> Date: Fri, 29 Jul 2011 08:53:00 -0400 In-Reply-To: (Will Newton's message of "Fri, 29 Jul 2011 11:07:09 +0100") Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shashidhar, On Fri, Jul 29 2011, Will Newton wrote: >>> The mask used inside this macro was assuming Buffer_Size1's[BS1's] >>> width to be 14 bits, >>> it is actually of 13 bits, Modified masks used in >>> IDMAC_SET_BUFFER1_SIZE such that >>> they use only 13 bits instead of current 14. >>> >>> Signed-off-by: Shashidhar Hiremath > > Yes, looks correct to me too (for some reason I didn't get the original mail). > > Acked-by: Will Newton Pushed to mmc-next for 3.1, thanks. (I didn't get the original mail either; it looks like the mailing lists rejected it for some reason.) - Chris. -- Chris Ball One Laptop Per Child