From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754277Ab1HKVi4 (ORCPT ); Thu, 11 Aug 2011 17:38:56 -0400 Received: from void.printf.net ([89.145.121.20]:35962 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754253Ab1HKViz (ORCPT ); Thu, 11 Aug 2011 17:38:55 -0400 From: Chris Ball To: Seungwon Jeon Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: dw_mmc: Fix DDR mode support. References: <1312515303-17169-1-git-send-email-tgih.jun@samsung.com> Date: Thu, 11 Aug 2011 17:38:49 -0400 In-Reply-To: <1312515303-17169-1-git-send-email-tgih.jun@samsung.com> (Seungwon Jeon's message of "Fri, 5 Aug 2011 12:35:03 +0900") Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Aug 04 2011, Seungwon Jeon wrote: > Host driver can't get a hint of DDR mode through ios->ddr flag anymore. > ios->timing is currently used to inform DDR mode as a substitute. > And capability of MMC_CAP_MMC_HIGHSPEED is added for DDR support. > > Signed-off-by: Seungwon Jeon > --- > drivers/mmc/host/dw_mmc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index d65511e..b412a1d 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -699,7 +699,7 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > } > > /* DDR mode set */ > - if (ios->ddr) { > + if (ios->timing == MMC_TIMING_UHS_DDR50) { > regs = mci_readl(slot->host, UHS_REG); > regs |= (0x1 << slot->id) << 16; > mci_writel(slot->host, UHS_REG, regs); > @@ -1646,7 +1646,7 @@ static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id) > mmc->caps |= MMC_CAP_4_BIT_DATA; > > if (host->pdata->quirks & DW_MCI_QUIRK_HIGHSPEED) > - mmc->caps |= MMC_CAP_SD_HIGHSPEED; > + mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; > > #ifdef CONFIG_MMC_DW_IDMAC > mmc->max_segs = host->ring_size; Thanks, pushed to mmc-next for 3.1 with Will's ACK. - Chris. -- Chris Ball One Laptop Per Child