From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/9] DM9000: change some printf to use debug instead
Date: Thu, 11 Aug 2011 10:01:42 +0200 [thread overview]
Message-ID: <m2k4akcr6h.fsf@ohwell.denx.de> (raw)
In-Reply-To: <4E438441.6040409@gmail.com> (Simon Schwarz's message of "Thu, 11 Aug 2011 09:26:57 +0200")
Hi Simon,
> Dear Eric Jarrige,
>
> On 08/10/2011 10:33 PM, Eric Jarrige wrote:
>> Signed-off-by: Eric Jarrige<eric.jarrige@armadeus.org>
>> Cc: Ben Warren<biggerbadderben@gmail.com>
>> ---
>> drivers/net/dm9000x.c | 8 ++++----
>> 1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c
>> index b5c5573..9cd0195 100644
>> --- a/drivers/net/dm9000x.c
>> +++ b/drivers/net/dm9000x.c
>> @@ -232,7 +232,7 @@ dm9000_probe(void)
>> id_val |= DM9000_ior(DM9000_PIDL)<< 16;
>> id_val |= DM9000_ior(DM9000_PIDH)<< 24;
>> if (id_val == DM9000_ID) {
>> - printf("dm9000 i/o: 0x%x, id: 0x%x \n", CONFIG_DM9000_BASE,
>> + DM9000_DBG("dm9000 i/o: 0x%x, id: 0x%x \n", CONFIG_DM9000_BASE,
>> id_val);
>> return 0;
>> } else {
>> @@ -298,19 +298,19 @@ static int dm9000_init(struct eth_device *dev, bd_t *bd)
>>
>> switch (io_mode) {
>> case 0x0: /* 16-bit mode */
>> - printf("DM9000: running in 16 bit mode\n");
>> + DM9000_DBG("DM9000: running in 16 bit mode\n");
> <snip>
>
> I'am just wondering: I see that DM9000_DBG is used all over dm9000 code
> - do you know the reason why not just use debug()?
Very likely only historical reasons as the code predates the DEBUG best
practice. Bow that you've identified it, we should change it ;)
Cheers
Detlev
--
It was actually a very beautiful thing to see a sunrise, cause' that's
such a calm time of day. It's a wonderful time of day to get ready to
go to bed.
-- Richard M. Stallman
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2011-08-11 8:01 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 20:33 [U-Boot] [PATCH 0/9] Series short description Eric Jarrige
2011-08-10 20:33 ` [U-Boot] [PATCH 1/9] mx1: export imx_gpio_mode() function Eric Jarrige
2011-08-10 20:33 ` [U-Boot] [PATCH 2/9] mx1: add i2c registers Eric Jarrige
2011-08-11 8:52 ` Stefano Babic
2011-08-11 23:49 ` Eric Jarrige
2011-10-06 22:04 ` Wolfgang Denk
2011-08-10 20:33 ` [U-Boot] [PATCH 3/9] apf9328: Add Armadeus Project board APF9328 Eric Jarrige
2011-08-11 8:50 ` Stefano Babic
2011-08-11 23:41 ` Eric Jarrige
2011-08-12 6:49 ` Stefano Babic
2011-08-17 7:31 ` Igor Grinberg
2011-08-17 21:58 ` Eric Jarrige
2011-08-18 6:20 ` Igor Grinberg
2011-08-18 8:51 ` Stefano Babic
2011-08-10 20:33 ` [U-Boot] [PATCH 4/9] apf9328: add apf9328 board in Makefile Eric Jarrige
2011-08-10 20:33 ` [U-Boot] [PATCH 5/9] apf9328: add default board configuration file Eric Jarrige
2011-08-11 9:21 ` Stefano Babic
2011-08-15 20:25 ` Eric Jarrige
2011-08-23 9:46 ` Stefano Babic
2011-08-24 4:50 ` Eric Jarrige
2011-08-23 11:26 ` Wolfgang Denk
2011-08-24 4:56 ` Eric Jarrige
2011-08-24 5:49 ` Wolfgang Denk
2011-08-24 6:34 ` Wolfgang Denk
2011-08-24 23:01 ` Eric Jarrige
2011-08-24 22:26 ` Eric Jarrige
2011-08-24 22:56 ` Wolfgang Denk
2011-08-24 6:22 ` Stefano Babic
2011-08-24 23:08 ` Eric Jarrige
2011-10-06 22:03 ` Wolfgang Denk
2011-08-10 20:33 ` [U-Boot] [PATCH 6/9] mx1: improve PLL freq computation Eric Jarrige
2011-08-11 9:22 ` Stefano Babic
2011-08-12 0:03 ` Eric Jarrige
2011-08-12 0:28 ` Eric Jarrige
2011-08-12 6:51 ` Stefano Babic
2011-08-10 20:33 ` [U-Boot] [PATCH 7/9] mx1: change a printf in speed.c to use debug instead Eric Jarrige
2011-08-10 20:33 ` [U-Boot] [PATCH 8/9] DM9000: change some printf " Eric Jarrige
2011-08-11 7:26 ` Simon Schwarz
2011-08-11 8:01 ` Detlev Zundel [this message]
2011-08-11 10:51 ` Eric Jarrige
2011-08-24 20:20 ` Wolfgang Denk
2011-08-24 23:04 ` Eric Jarrige
2011-08-25 3:19 ` Marek Vasut
2011-08-25 5:49 ` Wolfgang Denk
2011-08-11 9:27 ` Stefano Babic
2011-08-10 20:33 ` [U-Boot] [PATCH 9/9] arm920t: Fix jump to the relocated board_init_r Eric Jarrige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2k4akcr6h.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.