From: David Edmondson <dme@dme.org>
To: Zheng Chuan <zhengchuan@huawei.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: berrange@redhat.com, zhang.zhanghailiang@huawei.com,
quintela@redhat.com, qemu-devel@nongnu.org,
xiexiangyou@huawei.com, alex.chen@huawei.com,
ann.zhuangyanying@huawei.com, fangying1@huawei.com
Subject: Re: [PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page
Date: Thu, 27 Aug 2020 08:11:20 +0100 [thread overview]
Message-ID: <m2lfi0k1gn.fsf@dme.org> (raw)
In-Reply-To: <a86e273f-8bca-e789-d868-cb3832c162b4@huawei.com>
On Thursday, 2020-08-27 at 14:28:03 +08, Zheng Chuan wrote:
>>>> +static struct RamblockDirtyInfo *
>>>> +alloc_ramblock_dirty_info(int *block_index,
>>>> + struct RamblockDirtyInfo *block_dinfo)
>>>> +{
>>>> + struct RamblockDirtyInfo *info = NULL;
>>>> + int index = *block_index;
>>>> +
>>>> + if (!block_dinfo) {
>>>> + index = 0;
>>>> + block_dinfo = g_try_new(struct RamblockDirtyInfo, 1);
>>>> + } else {
>>>> + index++;
>>>> + block_dinfo = g_try_realloc(block_dinfo, (index + 1) *
>>>> + sizeof(struct RamblockDirtyInfo));
>>>
>>> g_try_renew() instead of g_try_realloc()?
>>>
> Hi,
> I am not sure that because there only one place in qemu to use g_try_renew.
> Could you tell me why, because i think g_try_realloc will also return NULL when error happen:)
Only suggested because it would make the two branches of the code more
similar.
dme.
--
And you can't hold me down, 'cause I belong to the hurricane.
next prev parent reply other threads:[~2020-08-27 7:29 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:14 [PATCH v5 00/12] *** A Method for evaluating dirty page rate *** Chuan Zheng
2020-08-24 9:14 ` [PATCH v5 01/12] migration/dirtyrate: setup up query-dirtyrate framwork Chuan Zheng
2020-08-24 9:14 ` [PATCH v5 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status Chuan Zheng
2020-08-26 9:22 ` David Edmondson
2020-08-24 9:14 ` [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info Chuan Zheng
2020-08-26 9:29 ` David Edmondson
2020-08-26 9:40 ` Zheng Chuan
2020-08-26 10:03 ` Zheng Chuan
2020-08-26 10:33 ` Dr. David Alan Gilbert
2020-08-26 10:53 ` David Edmondson
2020-08-24 9:14 ` [PATCH v5 04/12] migration/dirtyrate: Add dirtyrate statistics series functions Chuan Zheng
2020-08-24 9:14 ` [PATCH v5 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h Chuan Zheng
2020-08-24 9:14 ` [PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page Chuan Zheng
2020-08-26 9:56 ` David Edmondson
2020-08-26 12:30 ` Dr. David Alan Gilbert
2020-08-26 12:33 ` David Edmondson
2020-08-27 6:28 ` Zheng Chuan
2020-08-27 7:11 ` David Edmondson [this message]
2020-08-24 9:14 ` [PATCH v5 07/12] migration/dirtyrate: Compare page hash results for recorded " Chuan Zheng
2020-08-26 10:10 ` David Edmondson
2020-08-24 9:14 ` [PATCH v5 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE Chuan Zheng
2020-08-26 10:12 ` David Edmondson
2020-08-24 9:14 ` [PATCH v5 09/12] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period() Chuan Zheng
2020-08-26 10:17 ` David Edmondson
2020-08-27 8:01 ` Zheng Chuan
2020-08-27 8:12 ` Zheng Chuan
2020-08-27 8:30 ` David Edmondson
2020-08-24 9:14 ` [PATCH v5 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function Chuan Zheng
2020-08-26 10:21 ` David Edmondson
2020-08-27 8:16 ` Zheng Chuan
2020-08-24 9:14 ` [PATCH v5 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function Chuan Zheng
2020-08-26 10:26 ` David Edmondson
2020-08-27 9:34 ` Zheng Chuan
2020-08-27 11:58 ` David Edmondson
2020-08-27 12:55 ` Zheng Chuan
2020-08-27 13:07 ` David Edmondson
2020-08-27 14:47 ` Zheng Chuan
2020-08-27 15:36 ` David Edmondson
2020-08-24 9:14 ` [PATCH v5 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug Chuan Zheng
2020-08-24 16:50 ` [PATCH v5 00/12] *** A Method for evaluating dirty page rate *** no-reply
2020-08-25 1:40 Chuan Zheng
2020-08-25 1:40 ` [PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page Chuan Zheng
2020-08-26 12:35 ` Dr. David Alan Gilbert
2020-08-27 6:41 ` Zheng Chuan
2020-08-27 8:31 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2lfi0k1gn.fsf@dme.org \
--to=dme@dme.org \
--cc=alex.chen@huawei.com \
--cc=ann.zhuangyanying@huawei.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fangying1@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=xiexiangyou@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.