From: Kevin Hilman <khilman@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, Len Brown <len.brown@intel.com>,
Pavel Machek <pavel@ucw.cz>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lina Iyer <lina.iyer@linaro.org>,
Axel Haslam <ahaslam@baylibre.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jon Hunter <jonathanh@nvidia.com>,
Andy Gross <andy.gross@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 1/2] PM / Domains: Allow genpd to power on during the system PM phase
Date: Thu, 05 May 2016 12:31:08 +0200 [thread overview]
Message-ID: <m2shxwdcer.fsf@baylibre.com> (raw)
In-Reply-To: <1461673411-14245-2-git-send-email-ulf.hansson@linaro.org> (Ulf Hansson's message of "Tue, 26 Apr 2016 14:23:30 +0200")
Ulf Hansson <ulf.hansson@linaro.org> writes:
> If the PM domain is powered off when the first device in the domain starts
> its system PM prepare phase, genpd prevents any further attempts to power
> on the PM domain during the system PM phase. This constraint affects not
> only the current device which is being prepared, but all devices within
> the same PM domain.
>
> This behaviour needs to be changed, as a subsystem/driver for a device in
> the same PM domain may still need to be able to serve requests in the
> system PM phase. Accordingly, it may need to runtime resume its device and
> thus also request the corresponding PM domain to be powered on.
>
> To deal with these scenarios, let's make the device operational in the
> system PM prepare phase by runtime resuming it, no matter if the PM domain
> was powered on or not. Additionally allow the PM domain to be powered on
> via runtime PM during the system PM phase.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
LGTM. I would just request an update to the changelog saying a bit
about the suspend_power_off flag, which is used to track this condition,
which would also explain why it's removed in this patch.
Kevin
next prev parent reply other threads:[~2016-05-05 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 12:23 [PATCH 0/2] PM / Domains: Second step in improving system PM code in genpd Ulf Hansson
2016-04-26 12:23 ` [PATCH 1/2] PM / Domains: Allow genpd to power on during the system PM phase Ulf Hansson
2016-05-05 10:31 ` Kevin Hilman [this message]
2016-04-26 12:23 ` [PATCH 2/2] PM / Domains: Remove redundant wrapper functions for system PM Ulf Hansson
2016-05-05 10:42 ` Kevin Hilman
2016-04-27 21:29 ` [PATCH 0/2] PM / Domains: Second step in improving system PM code in genpd Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2shxwdcer.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=ahaslam@baylibre.com \
--cc=andy.gross@linaro.org \
--cc=geert+renesas@glider.be \
--cc=jonathanh@nvidia.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=len.brown@intel.com \
--cc=lina.iyer@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.