From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Tue, 19 Apr 2011 16:05:06 +0200 Subject: [U-Boot] [PATCH v2 0/6] TFTP server In-Reply-To: <1303143594-5345-1-git-send-email-luca.ceresoli@comelit.it> (Luca Ceresoli's message of "Mon, 18 Apr 2011 18:19:48 +0200") References: <1302796377-3321-1-git-send-email-luca.ceresoli@comelit.it> <1303143594-5345-1-git-send-email-luca.ceresoli@comelit.it> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Luca, > Hi, > here's the tftpsrv patch series, with checkpatch warnings fixed. > Only patches 2 and 3 are actually changed. Patch 1 is unchanged and patches 4-6 > have been simply rebased. > > There are still a few checkpatch issues (!), though, that I think can be ignored > and I'm not going to fix unless there's a specific request. > > Here they are: > >> WARNING: consider using kstrto* in preference to simple_strtol >> #125: FILE: net/tftp.c:619: >> + TftpRemotePort = simple_strtol(ep, NULL, 10); > Which is Linux-only > >> WARNING: do not add new typedefs >> #61: FILE: include/net.h:367: >> +typedef enum { BOOTP, RARP, ARP, TFTP, DHCP, PING, DNS, NFS, CDP, NETCONS, SNTP, > Is a typedef *enum* considered bad in U-Boot? For new code yes. We (well at least I) much rather prefer to see what type a variable is without looking up the typedef for it. Cheers Detlev -- F?r jemanden, der in eine Religion geboren wurde, in der das Ringen um eine einzige Seele ein Stafettenlauf ?ber viele Jahrhunderte sein kann [..], hat das Tempo des Christentums etwas Schwindelerregendes. Wenn der Hinduismus friedlich dahinflie?t wie der Ganges, dann ist das Christentum Toronto in der Rushhour. -- Yann Martel -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de