From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samir Bellabes Subject: Re: [RFC 7/9] snet: introduce snet_netlink.c and snet_netlink.h Date: Wed, 13 Jan 2010 05:28:30 +0100 Message-ID: References: <1262437456-24476-1-git-send-email-sam@synack.fr> <1262437456-24476-8-git-send-email-sam@synack.fr> <4B420464.3040301@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-security-module@vger.kernel.org, jamal , Evgeniy Polyakov , Neil Horman , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org To: Patrick McHardy Return-path: In-Reply-To: <4B420464.3040301@trash.net> (Patrick McHardy's message of "Mon, 04 Jan 2010 16:08:20 +0100") Sender: netfilter-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Patrick McHardy writes: > Samir Bellabes wrote: >> +++ b/security/snet/include/snet_netlink.h >> + SNET_A_VERSION, /* (NLA_U32) the snet protocol version */ > > You're using this to check for a "compliant protocol version" below. > This shouldn't be needed as any protocol changes need to be done > in a compatible fashion. what if userspace lib is using a old protocol version ? kernel and userspace will use incompatible protocol, which may result in errors. The idea of this 'version' mecanism is to prevent such incompatibilities, even if the userspace is (un)volontary not using the good library (which may be the one tagged in the same time as the kernel running) sam