From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node Date: Mon, 13 Jun 2016 15:09:55 -0700 Message-ID: References: <1465546915-24229-1-git-send-email-narmstrong@baylibre.com> <1465546915-24229-4-git-send-email-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Matt Mackall , Herbert Xu , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org To: Neil Armstrong Return-path: Received: from mail-pf0-f170.google.com ([209.85.192.170]:34955 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753707AbcFMWJ6 (ORCPT ); Mon, 13 Jun 2016 18:09:58 -0400 Received: by mail-pf0-f170.google.com with SMTP id c2so50153531pfa.2 for ; Mon, 13 Jun 2016 15:09:58 -0700 (PDT) In-Reply-To: <1465546915-24229-4-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Fri, 10 Jun 2016 10:21:55 +0200") Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi Neil, Neil Armstrong writes: > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > index 832815d..8353621 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > @@ -167,6 +167,11 @@ > }; > }; > > + rng { > + compatible = "amlogic,meson-rng"; > + reg = <0x0 0xc8834000 0x0 0x4>; > + }; This should be under the periphs bus, with an offset of 0x0 instead of at the top level. See the for-next branch in the linux-amlogic tree[1] which has separate busses for periphs and hiu. Kevin [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Mon, 13 Jun 2016 15:09:55 -0700 Subject: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node In-Reply-To: <1465546915-24229-4-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Fri, 10 Jun 2016 10:21:55 +0200") References: <1465546915-24229-1-git-send-email-narmstrong@baylibre.com> <1465546915-24229-4-git-send-email-narmstrong@baylibre.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Neil, Neil Armstrong writes: > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > index 832815d..8353621 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > @@ -167,6 +167,11 @@ > }; > }; > > + rng { > + compatible = "amlogic,meson-rng"; > + reg = <0x0 0xc8834000 0x0 0x4>; > + }; This should be under the periphs bus, with an offset of 0x0 instead of at the top level. See the for-next branch in the linux-amlogic tree[1] which has separate busses for periphs and hiu. Kevin [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Mon, 13 Jun 2016 15:09:55 -0700 Subject: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node In-Reply-To: <1465546915-24229-4-git-send-email-narmstrong@baylibre.com> (Neil Armstrong's message of "Fri, 10 Jun 2016 10:21:55 +0200") References: <1465546915-24229-1-git-send-email-narmstrong@baylibre.com> <1465546915-24229-4-git-send-email-narmstrong@baylibre.com> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Hi Neil, Neil Armstrong writes: > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > index 832815d..8353621 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > @@ -167,6 +167,11 @@ > }; > }; > > + rng { > + compatible = "amlogic,meson-rng"; > + reg = <0x0 0xc8834000 0x0 0x4>; > + }; This should be under the periphs bus, with an offset of 0x0 instead of at the top level. See the for-next branch in the linux-amlogic tree[1] which has separate busses for periphs and hiu. Kevin [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git