From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Mon, 09 Jul 2012 15:06:29 +0200 Subject: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration In-Reply-To: <20120709123142.0D774200166@gemini.denx.de> (Wolfgang Denk's message of "Mon, 09 Jul 2012 14:31:42 +0200") References: <1339063620-8890-1-git-send-email-valentin.longchamp@keymile.com> <1339063620-8890-13-git-send-email-valentin.longchamp@keymile.com> <4FE31D14.6080005@keymile.com> <4FF2C089.4000302@keymile.com> <4FFAC8C9.1020603@keymile.com> <20120709123142.0D774200166@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, [...] > If we place the driver in your board diretory, the chances are huge it > will simply sit there and rot, and the next one who needs something > similar will reinvent the wheel because he did not find your copy. > > I agree that even very simple and uncomplete implementations can co in > if the fulfil some purpose, and can form a basis for future > extensions. I just read through our documentation on the Wiki and found nothing relavant to such a topic. If we make this a requirement, we should add it so people know about it beforehand. How about amending the U-Boot design principles with 11. Keep It Generic - Generic code shall be added as high as possible to the U-Boot abstraction hierarchy and only as a last resort into board directories. This entails that peripheral drivers should be put below "drivers" even if they start out supporting only one specific configuration. Note that it is not a requirement for such a first instance to be generic as genericity generally cannot be extrapolated from a single data point. How does that sound? Cheers Detlev -- The only thing worse than generalizing from one example is generalizing from no examples at all. -- principles of X Window System -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de