From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59520)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1So9hl-0003D4-1d
	for qemu-devel@nongnu.org; Mon, 09 Jul 2012 04:52:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1So9hd-0005nC-AW
	for qemu-devel@nongnu.org; Mon, 09 Jul 2012 04:52:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30406)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1So9hd-0005mn-2J
	for qemu-devel@nongnu.org; Mon, 09 Jul 2012 04:52:21 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <cover.1341775234.git.blauwirbel@gmail.com>
	<cover.1341775234.git.blauwirbel@gmail.com>
	<fb2b3c37220e9852f8083c15b6bbd99c5e59bbcc.1341775234.git.blauwirbel@gmail.com>
Date: Mon, 09 Jul 2012 09:43:30 +0200
In-Reply-To: <fb2b3c37220e9852f8083c15b6bbd99c5e59bbcc.1341775234.git.blauwirbel@gmail.com>
	(blauwirbel@gmail.com's message of "Sun, 8 Jul 2012 19:22:33 +0000")
Message-ID: <m31ukl1isd.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH v2 3/3] bitops: use bool
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: blauwirbel@gmail.com
Cc: blueswirl@gmail.com, qemu-devel@nongnu.org

blauwirbel@gmail.com writes:

> From: Blue Swirl <blauwirbel@gmail.com>
>
> Use 'bool' type for return value of bit test functions.

Matter of taste.  'bool' makes sense if you think of these functions as
predicates (ugly ones, with side effects).  'int' makes sense if you
think of them as returning the bit value (a bit is not a truth value in
my book).

In my opinion, this is just unnecessary churn, and unnecessary deviation
from established kernel practice.