From: Juan Quintela <quintela@redhat.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 0/4] Fix VMState design flaws
Date: Mon, 14 Sep 2009 22:50:12 +0200 [thread overview]
Message-ID: <m31vm9jlob.fsf@neno.mitica> (raw)
In-Reply-To: <4AAEAC27.3070300@gnu.org> (Paolo Bonzini's message of "Mon, 14 Sep 2009 22:48:39 +0200")
Paolo Bonzini <bonzini@gnu.org> wrote:
>> * Add version_id field to post_load(). Now we can assign default values
>> in post_load for old versions of the state (ps2_kbd as example).
>
> While this is a good idea, why don't we first reset the devices upon
> load, which would also set the default values?...
It is safe to do that unconditionally?
If so, I am all for it. We can:
- add reset field to vmstate
- add default values to some fields, if it makse sense (haven't yet
looked at reset code).
Later, Juan.
next prev parent reply other threads:[~2009-09-14 20:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 20:15 [Qemu-devel] [PATCH 0/4] Fix VMState design flaws Juan Quintela
2009-09-14 20:15 ` [Qemu-devel] [PATCH 1/4] vmstate: remove const for put operations Juan Quintela
2009-09-14 20:15 ` [Qemu-devel] [PATCH 2/4] vmstate: add version_id argument to post_load Juan Quintela
2009-09-14 20:15 ` [Qemu-devel] [PATCH 3/4] vmstate: remove ps2_kbd_load_old() Juan Quintela
2009-09-14 20:45 ` [Qemu-devel] " Paolo Bonzini
2009-09-14 20:48 ` Juan Quintela
2009-09-14 20:15 ` [Qemu-devel] [PATCH 4/4] vmstate: Add support for sending partial arrays Juan Quintela
2009-09-14 20:48 ` [Qemu-devel] Re: [PATCH 0/4] Fix VMState design flaws Paolo Bonzini
2009-09-14 20:50 ` Juan Quintela [this message]
2009-09-14 21:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31vm9jlob.fsf@neno.mitica \
--to=quintela@redhat.com \
--cc=bonzini@gnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.