From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A79F4FA372B for ; Wed, 16 Oct 2019 13:44:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FA6821928 for ; Wed, 16 Oct 2019 13:44:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PR02Gxdt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393680AbfJPNoL (ORCPT ); Wed, 16 Oct 2019 09:44:11 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:51060 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729093AbfJPNoL (ORCPT ); Wed, 16 Oct 2019 09:44:11 -0400 Received: by mail-wm1-f65.google.com with SMTP id 5so3008679wmg.0; Wed, 16 Oct 2019 06:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=Bafgp4jYGnLo/xet8UtFIBOpzKesPTarPqBx8mm1ghI=; b=PR02Gxdt3nLUj5CA3FhgPxpb2Pejo0uJv6oewhFi4gFnZfhfQLk1KDR6cRT5Bg1Y8G b0Z8H6bCwhLBqk5nevl2yYyz3hmUxRfSO0R3TlgGrw3CLY/hcpwBPOgP9lX9wfc3GgV2 9oF7evBFpNZl8hoN5ENCFZ7nFmZNRJ2bSfKgR3P4NqbOKqz7XTgNkaa1w0fOZqroxfQy FRpBjAUAO4h3dChpTRrnH6DYycnW8hLiOjGTgK5sHDL5oRtptBl6QspTY1ITso1CmtmR 58U2hXO6xsWqgSwp1aQt2TqWCNyDO2UX0pP6hPm7zLbV9oQp8M93Tq8VqCMREHy0toHv PRsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=Bafgp4jYGnLo/xet8UtFIBOpzKesPTarPqBx8mm1ghI=; b=PJuxIPXRyEZ4JO71MwPtM4bTZpxqLVGwIe6ACVde8oESufeGLYxF/RQwA3SuevuZoG HIKGs3yMOhPFhDR3j1dVYdhahHDMI0a9Bww/0fyyUx8SP/VEWWGUWnIHXtduD+7p3fLv 6jBAOB+jCTNQabivyLlM9UXTx0oisk1aH7VAOxABugPxlTUxN+LrtH8T6U6ux7i3QBPk NtjWDcZvYECjGH1lXCH3khdCXhbdxqvBweVBjS85AQEOFr4jSWuJWy35HgTkW+B2CzgY N3me44E+/Wx1DC0QiV8hPTOdooZiok5+KVxobXVpVUn/PPupJqsnxP5lifP2nUDMCzS7 zIMg== X-Gm-Message-State: APjAAAVh+zVIsk4uFTFRBDMX32qs1hWZ9se1fhqJAe05KS9pbQSCGtwD 9XqgHk7KMEMSmiTI6luR1cXGbfRgxjo= X-Google-Smtp-Source: APXvYqyB+z261XSi/xNHUTIkW7HCqAaCgNNk5jZlZTw9o+jzwNhtu889hivFUMlUicQi2ELvoiv9yA== X-Received: by 2002:a1c:c90f:: with SMTP id f15mr3723254wmb.127.1571233447045; Wed, 16 Oct 2019 06:44:07 -0700 (PDT) Received: from arch-late (87-196-73-205.net.novis.pt. [87.196.73.205]) by smtp.gmail.com with ESMTPSA id r13sm37949311wrn.0.2019.10.16.06.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 06:44:06 -0700 (PDT) References: <20191015135915.6530-1-hslester96@gmail.com> <20191016090628.7l5u4ytdqr2jlasg@pengutronix.de> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Rui Miguel Silva To: Marco Felsch Cc: Chuhong Yuan , devel@driverdev.osuosl.org, Fabio Estevam , Pengutronix Kernel Team , Greg Kroah-Hartman , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Philipp Zabel , Steve Longerbeam , Mauro Carvalho Chehab , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get In-reply-to: <20191016090628.7l5u4ytdqr2jlasg@pengutronix.de> Date: Wed, 16 Oct 2019 14:43:59 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marco, On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: > Hi Chuhong, > > On 19-10-15 21:59, Chuhong Yuan wrote: >> devm_regulator_get may return an error but mipi_csis_phy_init misses >> a check for it. >> This may lead to problems when regulator_set_voltage uses the unchecked >> pointer. >> This patch adds a check for devm_regulator_get to avoid potential risk. >> >> Signed-off-by: Chuhong Yuan >> --- >> Changes in v2: >> - Add a check in mipi_csis_probe for the modified mipi_csis_phy_init. > > Did you miss the check for -EPROBE_DEFER? > I think nothing special is really needed to do in case of EPROBE_DEFER, or am I missing something? It just return to probe and probe returns also. I just talked about it because it was not cover in the original code. --- Cheers, Rui > > Regards, > Marco > >> >> drivers/staging/media/imx/imx7-mipi-csis.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c >> index 73d8354e618c..e8a6acaa969e 100644 >> --- a/drivers/staging/media/imx/imx7-mipi-csis.c >> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c >> @@ -350,6 +350,8 @@ static void mipi_csis_sw_reset(struct csi_state *state) >> static int mipi_csis_phy_init(struct csi_state *state) >> { >> state->mipi_phy_regulator = devm_regulator_get(state->dev, "phy"); >> + if (IS_ERR(state->mipi_phy_regulator)) >> + return PTR_ERR(state->mipi_phy_regulator); >> >> return regulator_set_voltage(state->mipi_phy_regulator, 1000000, >> 1000000); >> @@ -966,7 +968,10 @@ static int mipi_csis_probe(struct platform_device *pdev) >> return ret; >> } >> >> - mipi_csis_phy_init(state); >> + ret = mipi_csis_phy_init(state); >> + if (ret < 0) >> + return ret; >> + >> mipi_csis_phy_reset(state); >> >> mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> -- >> 2.20.1 >> >> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA4BFA372A for ; Wed, 16 Oct 2019 13:44:15 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0165D21928 for ; Wed, 16 Oct 2019 13:44:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PR02Gxdt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0165D21928 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C796686966; Wed, 16 Oct 2019 13:44:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sEbUWuYArD1I; Wed, 16 Oct 2019 13:44:11 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id B151586969; Wed, 16 Oct 2019 13:44:11 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id D313E1BF2AA for ; Wed, 16 Oct 2019 13:44:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id CF3FF203C7 for ; Wed, 16 Oct 2019 13:44:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yUhhID2fZEjR for ; Wed, 16 Oct 2019 13:44:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by silver.osuosl.org (Postfix) with ESMTPS id F316320425 for ; Wed, 16 Oct 2019 13:44:08 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id y135so4725600wmc.1 for ; Wed, 16 Oct 2019 06:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=Bafgp4jYGnLo/xet8UtFIBOpzKesPTarPqBx8mm1ghI=; b=PR02Gxdt3nLUj5CA3FhgPxpb2Pejo0uJv6oewhFi4gFnZfhfQLk1KDR6cRT5Bg1Y8G b0Z8H6bCwhLBqk5nevl2yYyz3hmUxRfSO0R3TlgGrw3CLY/hcpwBPOgP9lX9wfc3GgV2 9oF7evBFpNZl8hoN5ENCFZ7nFmZNRJ2bSfKgR3P4NqbOKqz7XTgNkaa1w0fOZqroxfQy FRpBjAUAO4h3dChpTRrnH6DYycnW8hLiOjGTgK5sHDL5oRtptBl6QspTY1ITso1CmtmR 58U2hXO6xsWqgSwp1aQt2TqWCNyDO2UX0pP6hPm7zLbV9oQp8M93Tq8VqCMREHy0toHv PRsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=Bafgp4jYGnLo/xet8UtFIBOpzKesPTarPqBx8mm1ghI=; b=JOc9p/Uo27Gjk8mR6Wvaj/q33hapDiyE1Li9wK54YC0ipS2Npt3mNML+Nz2et/zKCl F+llPmbZprzJAm7Ksb3ZQTi56VdhttMx5EtAFvyTGRHZBVdYvK8MxMzHQ75hVpYMI1fG qjjuNO9rdCGt/Cr1Dt+ESHXQ8Tp7UxTSPN8rA5RTQC+Oig32r2CbiNKGwlGNMKZSrQbl tb99l+CyRqoguEbHObbZTZBGaxQWaxFk1nOkAewBRMoLrC+beC2GYWjuWrFv7LVBTEJF W25gu8PSIpKF3h8+Gl0RcxqTWU7exBCMewnBlJY2/Gy4EHTS4aApCW+Wb8/iBi5L3dCd 1iyw== X-Gm-Message-State: APjAAAXCQyLsqq1kJaHSkOwKFTlZBU9RLHw387eDLwi8VqMMPSzOOjFy DCrWygGz15h7ieIajyN700I= X-Google-Smtp-Source: APXvYqyB+z261XSi/xNHUTIkW7HCqAaCgNNk5jZlZTw9o+jzwNhtu889hivFUMlUicQi2ELvoiv9yA== X-Received: by 2002:a1c:c90f:: with SMTP id f15mr3723254wmb.127.1571233447045; Wed, 16 Oct 2019 06:44:07 -0700 (PDT) Received: from arch-late (87-196-73-205.net.novis.pt. [87.196.73.205]) by smtp.gmail.com with ESMTPSA id r13sm37949311wrn.0.2019.10.16.06.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 06:44:06 -0700 (PDT) References: <20191015135915.6530-1-hslester96@gmail.com> <20191016090628.7l5u4ytdqr2jlasg@pengutronix.de> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Rui Miguel Silva To: Marco Felsch Subject: Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get In-reply-to: <20191016090628.7l5u4ytdqr2jlasg@pengutronix.de> Date: Wed, 16 Oct 2019 14:43:59 +0100 Message-ID: MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Philipp Zabel , Greg Kroah-Hartman , Sascha Hauer , Chuhong Yuan , linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Steve Longerbeam , Shawn Guo , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Marco, On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: > Hi Chuhong, > > On 19-10-15 21:59, Chuhong Yuan wrote: >> devm_regulator_get may return an error but mipi_csis_phy_init misses >> a check for it. >> This may lead to problems when regulator_set_voltage uses the unchecked >> pointer. >> This patch adds a check for devm_regulator_get to avoid potential risk. >> >> Signed-off-by: Chuhong Yuan >> --- >> Changes in v2: >> - Add a check in mipi_csis_probe for the modified mipi_csis_phy_init. > > Did you miss the check for -EPROBE_DEFER? > I think nothing special is really needed to do in case of EPROBE_DEFER, or am I missing something? It just return to probe and probe returns also. I just talked about it because it was not cover in the original code. --- Cheers, Rui > > Regards, > Marco > >> >> drivers/staging/media/imx/imx7-mipi-csis.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c >> index 73d8354e618c..e8a6acaa969e 100644 >> --- a/drivers/staging/media/imx/imx7-mipi-csis.c >> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c >> @@ -350,6 +350,8 @@ static void mipi_csis_sw_reset(struct csi_state *state) >> static int mipi_csis_phy_init(struct csi_state *state) >> { >> state->mipi_phy_regulator = devm_regulator_get(state->dev, "phy"); >> + if (IS_ERR(state->mipi_phy_regulator)) >> + return PTR_ERR(state->mipi_phy_regulator); >> >> return regulator_set_voltage(state->mipi_phy_regulator, 1000000, >> 1000000); >> @@ -966,7 +968,10 @@ static int mipi_csis_probe(struct platform_device *pdev) >> return ret; >> } >> >> - mipi_csis_phy_init(state); >> + ret = mipi_csis_phy_init(state); >> + if (ret < 0) >> + return ret; >> + >> mipi_csis_phy_reset(state); >> >> mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> -- >> 2.20.1 >> >> >> _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3F98FA372A for ; Wed, 16 Oct 2019 13:44:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A55E3218DE for ; Wed, 16 Oct 2019 13:44:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wl+I2AsG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PR02Gxdt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A55E3218DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=I/q1feZLDwwroKEUyu8AbojdV1Og+fJNEDkFEgQP6Zw=; b=Wl+I2AsGkCjJrmaDg+UYAkjWFz +XR+IzuzEqgiroOnCEWf4MPTlHtEoEN8Nkx5swWK0PJPnAYD/asYPy9xg7k6AxNtS3s3vXeox8aQ2 CnqY805vDx1oXvLQQWpPB4uvC6z9jFoJw9JkCgSaRGyUel2sELJX2jQdDR5k5BwAo6ACW+etrsvGh obVW+aiL4HR+FgdqSqphQ8RkhDEK1/CCJrY2wVOJJkqnVgR/nTLJTucdXJcaBTIc0ZXf/Wyih+eOs ei0NlYp61GvQjamYtOM1xgMIymlb/xHMLNFnwg2rEFzgU84g/DOdnek/8BcmsJdvFmXEIy9KzBcIf HiXNlO5w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKjb1-0000LU-8I; Wed, 16 Oct 2019 13:44:11 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKjay-0000JI-Nq for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2019 13:44:10 +0000 Received: by mail-wm1-x342.google.com with SMTP id r19so2996604wmh.2 for ; Wed, 16 Oct 2019 06:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=Bafgp4jYGnLo/xet8UtFIBOpzKesPTarPqBx8mm1ghI=; b=PR02Gxdt3nLUj5CA3FhgPxpb2Pejo0uJv6oewhFi4gFnZfhfQLk1KDR6cRT5Bg1Y8G b0Z8H6bCwhLBqk5nevl2yYyz3hmUxRfSO0R3TlgGrw3CLY/hcpwBPOgP9lX9wfc3GgV2 9oF7evBFpNZl8hoN5ENCFZ7nFmZNRJ2bSfKgR3P4NqbOKqz7XTgNkaa1w0fOZqroxfQy FRpBjAUAO4h3dChpTRrnH6DYycnW8hLiOjGTgK5sHDL5oRtptBl6QspTY1ITso1CmtmR 58U2hXO6xsWqgSwp1aQt2TqWCNyDO2UX0pP6hPm7zLbV9oQp8M93Tq8VqCMREHy0toHv PRsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=Bafgp4jYGnLo/xet8UtFIBOpzKesPTarPqBx8mm1ghI=; b=jUdwxXSRJ4vC2FR4UtdSyY9VERDXYNcGFTRivlfg/IF8vz/wHmisTACis9qe/9gt7R Wp5N2XyN60v3ey2s/yIpuWGGnalFOSWo2sEODmpaBDea2eIkiTL5IdWBqbkwYsdQ7++g 6YfPCzAGkxeT1V6PJQ+3WPO00aF3a1c8rvqJ2VuXd2NpRxmwD0y3MqCG9xgIFZCm3rAc llPM8dGJZJdF7mfFD1B3sKYiBabnG4FaNiePyjLWFf1uIvHczSeBfcwU4BPUSPVwd4yt ePB1kXhHWTrIDG4dWe09ZMlVwtC2l3JpgHih9CH17rkx8PfKTP2Y7SMDWpNJrK0HdtRp zY/Q== X-Gm-Message-State: APjAAAXOxahrLoa8TOjwWIXRTKy+CB/DaGv58l3n/dntVCZHQQXgt0GY k8PdHZn1ebaNOAriG6p/16U= X-Google-Smtp-Source: APXvYqyB+z261XSi/xNHUTIkW7HCqAaCgNNk5jZlZTw9o+jzwNhtu889hivFUMlUicQi2ELvoiv9yA== X-Received: by 2002:a1c:c90f:: with SMTP id f15mr3723254wmb.127.1571233447045; Wed, 16 Oct 2019 06:44:07 -0700 (PDT) Received: from arch-late (87-196-73-205.net.novis.pt. [87.196.73.205]) by smtp.gmail.com with ESMTPSA id r13sm37949311wrn.0.2019.10.16.06.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 06:44:06 -0700 (PDT) References: <20191015135915.6530-1-hslester96@gmail.com> <20191016090628.7l5u4ytdqr2jlasg@pengutronix.de> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Rui Miguel Silva To: Marco Felsch Subject: Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get In-reply-to: <20191016090628.7l5u4ytdqr2jlasg@pengutronix.de> Date: Wed, 16 Oct 2019 14:43:59 +0100 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_064408_874296_8903D45A X-CRM114-Status: GOOD ( 15.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Philipp Zabel , Greg Kroah-Hartman , Sascha Hauer , Chuhong Yuan , linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Steve Longerbeam , Shawn Guo , Mauro Carvalho Chehab , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marco, On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: > Hi Chuhong, > > On 19-10-15 21:59, Chuhong Yuan wrote: >> devm_regulator_get may return an error but mipi_csis_phy_init misses >> a check for it. >> This may lead to problems when regulator_set_voltage uses the unchecked >> pointer. >> This patch adds a check for devm_regulator_get to avoid potential risk. >> >> Signed-off-by: Chuhong Yuan >> --- >> Changes in v2: >> - Add a check in mipi_csis_probe for the modified mipi_csis_phy_init. > > Did you miss the check for -EPROBE_DEFER? > I think nothing special is really needed to do in case of EPROBE_DEFER, or am I missing something? It just return to probe and probe returns also. I just talked about it because it was not cover in the original code. --- Cheers, Rui > > Regards, > Marco > >> >> drivers/staging/media/imx/imx7-mipi-csis.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c >> index 73d8354e618c..e8a6acaa969e 100644 >> --- a/drivers/staging/media/imx/imx7-mipi-csis.c >> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c >> @@ -350,6 +350,8 @@ static void mipi_csis_sw_reset(struct csi_state *state) >> static int mipi_csis_phy_init(struct csi_state *state) >> { >> state->mipi_phy_regulator = devm_regulator_get(state->dev, "phy"); >> + if (IS_ERR(state->mipi_phy_regulator)) >> + return PTR_ERR(state->mipi_phy_regulator); >> >> return regulator_set_voltage(state->mipi_phy_regulator, 1000000, >> 1000000); >> @@ -966,7 +968,10 @@ static int mipi_csis_probe(struct platform_device *pdev) >> return ret; >> } >> >> - mipi_csis_phy_init(state); >> + ret = mipi_csis_phy_init(state); >> + if (ret < 0) >> + return ret; >> + >> mipi_csis_phy_reset(state); >> >> mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> -- >> 2.20.1 >> >> >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel