From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Raghavendra D Prabhu <rprabhu@wnohang.net>,
qemu-devel@nongnu.org,
Raghavendra D Prabhu <raghu.prabhu13@gmail.com>,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)
Date: Tue, 05 Jul 2011 09:49:56 +0200 [thread overview]
Message-ID: <m34o31b1zv.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA-sdv2W_xQcGtKw5Lvkndpve_yTLsV=vMuwFVpFLM-e3w@mail.gmail.com> (Peter Maydell's message of "Tue, 5 Jul 2011 08:02:36 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> On 5 July 2011 07:15, Markus Armbruster <armbru@redhat.com> wrote:
>>> + int fd, __attribute__((unused)) ret;
>>>
>>> snprintf(reset_file, sizeof(reset_file),
>>> "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/reset",
>>
>> What about (void)write() and do away with ret?
>
> If 'ret' has been used to silence compiler warnings about functions
> which have been declared with attribute __warn_unused_result__
> (eg write() and various other libc functions) then "(void)write()"
> is insufficient -- gcc requires the variable.
gcc being silly. Oh well.
next prev parent reply other threads:[~2011-07-05 7:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 21:59 [PATCH 0/3] Build fixes Raghavendra D Prabhu
2011-07-04 21:59 ` [Qemu-devel] " Raghavendra D Prabhu
2011-07-04 22:00 ` [PATCH 1/3] Avoid the use of deprecated gnutls gnutls_*_set_priority functions Raghavendra D Prabhu
2011-07-04 22:00 ` [Qemu-devel] " Raghavendra D Prabhu
2011-08-22 8:26 ` Stefan Hajnoczi
2011-08-22 8:26 ` [Qemu-devel] " Stefan Hajnoczi
2011-08-22 10:13 ` Gerd Hoffmann
2011-08-22 10:13 ` [Qemu-devel] " Gerd Hoffmann
2011-08-25 10:54 ` Stefan Hajnoczi
2011-08-25 10:54 ` [Qemu-devel] " Stefan Hajnoczi
2011-08-25 11:02 ` Daniel P. Berrange
2011-08-25 11:02 ` [Qemu-devel] " Daniel P. Berrange
2011-07-04 22:00 ` [PATCH 2/3] Add fno-strict-overflow Raghavendra D Prabhu
2011-07-04 22:00 ` [Qemu-devel] " Raghavendra D Prabhu
2011-07-04 22:38 ` Peter Maydell
2011-07-04 22:38 ` Peter Maydell
2011-07-05 5:41 ` Stefan Hajnoczi
2011-07-05 5:41 ` Stefan Hajnoczi
2011-07-05 9:34 ` Stefan Hajnoczi
2011-07-05 9:34 ` Stefan Hajnoczi
2011-07-05 15:36 ` Raghavendra D Prabhu
2011-07-05 20:30 ` Stefan Hajnoczi
2011-07-07 21:51 ` Raghavendra D Prabhu
2011-07-04 22:00 ` [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror) Raghavendra D Prabhu
2011-07-04 22:00 ` [Qemu-devel] " Raghavendra D Prabhu
2011-07-05 6:15 ` Markus Armbruster
2011-07-05 6:15 ` Markus Armbruster
2011-07-05 7:02 ` Peter Maydell
2011-07-05 7:02 ` Peter Maydell
2011-07-05 7:49 ` Markus Armbruster [this message]
2011-07-05 8:05 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34o31b1zv.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=raghu.prabhu13@gmail.com \
--cc=rprabhu@wnohang.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.