From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43900)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QbXLJ-0003xO-HA
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 08:24:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QbXLH-0008AJ-U0
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 08:24:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60495)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QbXLH-0008A9-Gl
	for qemu-devel@nongnu.org; Tue, 28 Jun 2011 08:24:35 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5SCOY9f006020
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 28 Jun 2011 08:24:34 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1305805037-17752-1-git-send-email-armbru@redhat.com>
	<m3d3i38ms7.fsf@blackfin.pond.sub.org>
	<20110627095420.GG9369@amit-x200.redhat.com>
	<m3mxh3jvt0.fsf@blackfin.pond.sub.org>
	<20110628112646.GB25491@amit-x200.redhat.com>
Date: Tue, 28 Jun 2011 14:24:32 +0200
In-Reply-To: <20110628112646.GB25491@amit-x200.redhat.com> (Amit Shah's
	message of "Tue, 28 Jun 2011 16:56:46 +0530")
Message-ID: <m34o3a16v3.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: alevy@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com

Amit Shah <amit.shah@redhat.com> writes:

> On (Mon) 27 Jun 2011 [14:36:11], Markus Armbruster wrote:
>> Amit Shah <amit.shah@redhat.com> writes:
>> 
>> > On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote:
>> >> Ping?
>> >
>> > There were a couple of things:
>> >
>> >>             port 0, guest on, host off, throttle off
>> >
>> > guest on/off, host on/off doesn't convey much -- what's on/off?
>> >
>> > Also, 'throttle' could be 'thottled'?
>> 
>> Discussion petered out with my message[*]:
>> 
>>     I chose on/off to stay consistent with how qdev shows bool
>>     properties (print_bit() in qdev-properties.c).  May be misguided.
>>     Like you, I'm having difficulties coming up with a better version
>>     that is still consise.
>>     
>>     But: should "info qtree" show such device state?  It's about
>>     configuration of the device tree, isn't it?  Connection status is
>>     useful to know, but it's not device configuration.  Other
>>     print_dev() methods may cross that line, too.  For instance,
>>     usb_bus_dev_print() prints attached, which looks suspicious (commit
>>     66a6593a).
>> 
>> Should info qtree continue to show this information?  If yes, care to
>> suggest a better format?
>
> Don't know.  I'm fine with anything the qdev guys decide.  I agree
> this isn't device state.

Unfortunately, there's no qdev maintainer making descisions.

What shall we do now?

1. Commit as is.  Need an ACK then.

2. Respin with virtser_bus_dev_print() printing the same stuff prettier.
Need ideas on a prettier format.

3. Respin with virtser_bus_dev_print() printing less stuff, but
prettier.  Need ideas on what exactly to print, and how.