From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlhva-0002i7-RI for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:44:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlhvT-0003SS-RH for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:44:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlhvT-0003SG-KM for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:43:59 -0400 From: Markus Armbruster References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-34-git-send-email-armbru@redhat.com> <20110726121722.GR1418@lst.de> Date: Tue, 26 Jul 2011 15:43:53 +0200 In-Reply-To: <20110726121722.GR1418@lst.de> (Christoph Hellwig's message of "Tue, 26 Jul 2011 14:17:22 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray state mismatch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:24:07PM +0200, Markus Armbruster wrote: >> When ide-cd is backed by a physical drive, we want the physical tray >> match the virtual one. To that end, we call bdrv_eject() on guest's >> load/eject, and bdrv_lock_medium() on guest's prevent/allow removal. >> But we don't set the initial state on device model init. Fix that. >> >> While there, also unlock on device model exit. > > Looks good, > > Reviewed-by: Christoph Hellwig > > But wondering: do you actually use the physical CDROM passthrough? In my opinion, it's one of the QEMU features friends don't let friends use. But it's there, I can fix it a little, so I fix it a little. A wiser man would perhaps close his eyes and move on to fix something more useful :)