From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOrkx-00032D-RE for qemu-devel@nongnu.org; Tue, 24 May 2011 09:34:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QOrkw-0007GV-Rk for qemu-devel@nongnu.org; Tue, 24 May 2011 09:34:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOrkw-0007GL-Ks for qemu-devel@nongnu.org; Tue, 24 May 2011 09:34:42 -0400 From: Markus Armbruster References: <1306237507-19189-1-git-send-email-pbonzini@redhat.com> <1306237507-19189-2-git-send-email-pbonzini@redhat.com> <4DDBADDF.5030904@redhat.com> Date: Tue, 24 May 2011 15:34:37 +0200 In-Reply-To: <4DDBADDF.5030904@redhat.com> (Paolo Bonzini's message of "Tue, 24 May 2011 15:08:47 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: david@gibson.dropbear.id.au, qemu-devel@nongnu.org, agraf@suse.de Paolo Bonzini writes: > On 05/24/2011 03:03 PM, Markus Armbruster wrote: >> > This is particularly important with the conversion from scsi-disk >> > to scsi-{cd,hd} that Markus made. After his patches, if you >> > specify a scsi-cd device attached to an if=none drive, the default >> > VSCSI controller will not be created and, without qdevification, >> > you will not be able to add yours. >> >> Really? Hasn't that always been the case? > > What hasn't always been the case? :) > > 1) "the default VSCSI controller will not be created" -- no, this is > new with scsi-cd: scsi-disk never was on the default_driver_table in > vl.c, as you said in the commit message for af6bf13 (defaults: ide-cd, > ide-hd and scsi-cd devices suppress default CD-ROM, 2011-05-18). In > fact, I believe you could add scsi-hd there too. Aha. The default CD-ROM also creates a default controller if machine->use_scsi. But as soon as you try -device scsi-cd, it vanishes. Hmm. > 2) "without qdevification, you will not be able to add yours" -- that > of course has always been the case. But I never noticed because there > was no way to avoid creating the default CD-ROM, and this in turn > forced the non-qdev-clean creation of the VSCSI controller. There's -nodefaults.