* [PATCH 1/42] drivers/net/wan: Adjust confusing if indentation
@ 2010-08-05 20:17 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2010-08-05 20:17 UTC (permalink / raw)
To: Krzysztof Halasa, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Indent the branch of an if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/wan/c101.c | 2 +-
drivers/net/wan/n2.c | 2 +-
drivers/net/wan/pci200syn.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c
index 0bd898c..4ac85a0 100644
--- a/drivers/net/wan/c101.c
+++ b/drivers/net/wan/c101.c
@@ -264,7 +264,7 @@ static int c101_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
new_line.clock_type != CLOCK_TXFROMRX &&
new_line.clock_type != CLOCK_INT &&
new_line.clock_type != CLOCK_TXINT)
- return -EINVAL; /* No such clock setting */
+ return -EINVAL; /* No such clock setting */
if (new_line.loopback != 0 && new_line.loopback != 1)
return -EINVAL;
diff --git a/drivers/net/wan/n2.c b/drivers/net/wan/n2.c
index 5394b51..7a3720f 100644
--- a/drivers/net/wan/n2.c
+++ b/drivers/net/wan/n2.c
@@ -282,7 +282,7 @@ static int n2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
new_line.clock_type != CLOCK_TXFROMRX &&
new_line.clock_type != CLOCK_INT &&
new_line.clock_type != CLOCK_TXINT)
- return -EINVAL; /* No such clock setting */
+ return -EINVAL; /* No such clock setting */
if (new_line.loopback != 0 && new_line.loopback != 1)
return -EINVAL;
diff --git a/drivers/net/wan/pci200syn.c b/drivers/net/wan/pci200syn.c
index e2cff64..fd73759 100644
--- a/drivers/net/wan/pci200syn.c
+++ b/drivers/net/wan/pci200syn.c
@@ -220,7 +220,7 @@ static int pci200_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
new_line.clock_type != CLOCK_TXFROMRX &&
new_line.clock_type != CLOCK_INT &&
new_line.clock_type != CLOCK_TXINT)
- return -EINVAL; /* No such clock setting */
+ return -EINVAL; /* No such clock setting */
if (new_line.loopback != 0 && new_line.loopback != 1)
return -EINVAL;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/42] drivers/net/wan: Adjust confusing if indentation
@ 2010-08-05 20:17 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2010-08-05 20:17 UTC (permalink / raw)
To: Krzysztof Halasa, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Indent the branch of an if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column = p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/wan/c101.c | 2 +-
drivers/net/wan/n2.c | 2 +-
drivers/net/wan/pci200syn.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c
index 0bd898c..4ac85a0 100644
--- a/drivers/net/wan/c101.c
+++ b/drivers/net/wan/c101.c
@@ -264,7 +264,7 @@ static int c101_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
new_line.clock_type != CLOCK_TXFROMRX &&
new_line.clock_type != CLOCK_INT &&
new_line.clock_type != CLOCK_TXINT)
- return -EINVAL; /* No such clock setting */
+ return -EINVAL; /* No such clock setting */
if (new_line.loopback != 0 && new_line.loopback != 1)
return -EINVAL;
diff --git a/drivers/net/wan/n2.c b/drivers/net/wan/n2.c
index 5394b51..7a3720f 100644
--- a/drivers/net/wan/n2.c
+++ b/drivers/net/wan/n2.c
@@ -282,7 +282,7 @@ static int n2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
new_line.clock_type != CLOCK_TXFROMRX &&
new_line.clock_type != CLOCK_INT &&
new_line.clock_type != CLOCK_TXINT)
- return -EINVAL; /* No such clock setting */
+ return -EINVAL; /* No such clock setting */
if (new_line.loopback != 0 && new_line.loopback != 1)
return -EINVAL;
diff --git a/drivers/net/wan/pci200syn.c b/drivers/net/wan/pci200syn.c
index e2cff64..fd73759 100644
--- a/drivers/net/wan/pci200syn.c
+++ b/drivers/net/wan/pci200syn.c
@@ -220,7 +220,7 @@ static int pci200_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
new_line.clock_type != CLOCK_TXFROMRX &&
new_line.clock_type != CLOCK_INT &&
new_line.clock_type != CLOCK_TXINT)
- return -EINVAL; /* No such clock setting */
+ return -EINVAL; /* No such clock setting */
if (new_line.loopback != 0 && new_line.loopback != 1)
return -EINVAL;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/42] drivers/net/wan: Adjust confusing if indentation
2010-08-05 20:17 ` Julia Lawall
@ 2010-08-07 12:37 ` Krzysztof Halasa
-1 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Halasa @ 2010-08-07 12:37 UTC (permalink / raw)
To: Julia Lawall; +Cc: netdev, linux-kernel, kernel-janitors
Julia Lawall <julia@diku.dk> writes:
> drivers/net/wan/c101.c | 2 +-
> drivers/net/wan/n2.c | 2 +-
> drivers/net/wan/pci200syn.c | 2 +-
Fully Acked-by: Krzysztof Hałasa <khc@pm.waw.pl>
Thanks.
--
Krzysztof Halasa
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/42] drivers/net/wan: Adjust confusing if indentation
@ 2010-08-07 12:37 ` Krzysztof Halasa
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Halasa @ 2010-08-07 12:37 UTC (permalink / raw)
To: Julia Lawall; +Cc: netdev, linux-kernel, kernel-janitors
Julia Lawall <julia@diku.dk> writes:
> drivers/net/wan/c101.c | 2 +-
> drivers/net/wan/n2.c | 2 +-
> drivers/net/wan/pci200syn.c | 2 +-
Fully Acked-by: Krzysztof Hałasa <khc@pm.waw.pl>
Thanks.
--
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/42] drivers/net/wan: Adjust confusing if indentation
2010-08-07 12:37 ` Krzysztof Halasa
@ 2010-08-17 3:57 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2010-08-17 3:57 UTC (permalink / raw)
To: khc; +Cc: julia, netdev, linux-kernel, kernel-janitors
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: Sat, 07 Aug 2010 14:37:37 +0200
> Julia Lawall <julia@diku.dk> writes:
>
>> drivers/net/wan/c101.c | 2 +-
>> drivers/net/wan/n2.c | 2 +-
>> drivers/net/wan/pci200syn.c | 2 +-
>
> Fully Acked-by: Krzysztof Hałasa <khc@pm.waw.pl>
Please don't use non-standard commit tags like this "Fully Acked-by:"
thing, otherwise automated tools won't notice and pick them up
properly.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/42] drivers/net/wan: Adjust confusing if indentation
@ 2010-08-17 3:57 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2010-08-17 3:57 UTC (permalink / raw)
To: khc; +Cc: julia, netdev, linux-kernel, kernel-janitors
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: Sat, 07 Aug 2010 14:37:37 +0200
> Julia Lawall <julia@diku.dk> writes:
>
>> drivers/net/wan/c101.c | 2 +-
>> drivers/net/wan/n2.c | 2 +-
>> drivers/net/wan/pci200syn.c | 2 +-
>
> Fully Acked-by: Krzysztof Ha©©asa <khc@pm.waw.pl>
Please don't use non-standard commit tags like this "Fully Acked-by:"
thing, otherwise automated tools won't notice and pick them up
properly.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/42] drivers/net/wan: Adjust confusing if indentation
2010-08-05 20:17 ` Julia Lawall
@ 2010-08-17 8:49 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2010-08-17 8:49 UTC (permalink / raw)
To: julia; +Cc: khc, netdev, linux-kernel, kernel-janitors
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/42] drivers/net/wan: Adjust confusing if indentation
@ 2010-08-17 8:49 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2010-08-17 8:49 UTC (permalink / raw)
To: julia; +Cc: khc, netdev, linux-kernel, kernel-janitors
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-08-17 8:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-05 20:17 [PATCH 1/42] drivers/net/wan: Adjust confusing if indentation Julia Lawall
2010-08-05 20:17 ` Julia Lawall
2010-08-07 12:37 ` Krzysztof Halasa
2010-08-07 12:37 ` Krzysztof Halasa
2010-08-17 3:57 ` David Miller
2010-08-17 3:57 ` David Miller
2010-08-17 8:49 ` David Miller
2010-08-17 8:49 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.