From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0Tlz-0003FB-W5 for qemu-devel@nongnu.org; Mon, 05 Sep 2011 03:39:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0Tly-00081I-S9 for qemu-devel@nongnu.org; Mon, 05 Sep 2011 03:39:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0Tly-000811-Jv for qemu-devel@nongnu.org; Mon, 05 Sep 2011 03:39:14 -0400 From: Markus Armbruster References: <1314891739-1881-1-git-send-email-kraxel@redhat.com> <1314891739-1881-2-git-send-email-kraxel@redhat.com> <4E5FDEE0.2010908@codemonkey.ws> <4E6088CA.4030005@redhat.com> Date: Mon, 05 Sep 2011 09:39:09 +0200 In-Reply-To: <4E6088CA.4030005@redhat.com> (Gerd Hoffmann's message of "Fri, 02 Sep 2011 09:42:02 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1/4] Probe for libcheck by default. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann writes: > On 09/01/11 21:37, Anthony Liguori wrote: >> On 09/01/2011 10:42 AM, Gerd Hoffmann wrote: >>> Probe for libcheck and build checks (if found) by default. >>> Can be explicitly disabled using --disable-check-utests. >>> >>> Signed-off-by: Gerd Hoffmann >>> --- >>> configure | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> I think we should convert the check tests to gtest, and then have make >> check use gtester and gtester-report generate a single report of all of >> the test cases. > > I wouldn't object, that is *way* beyond the scope of this little patch > series though. One step at a time. >> We could then have build bot run make check and post the output. > > Running "make check" in buildbot is indeed the motivation to do this ;) > >> I don't >> want to end up with a bunch of non gtest unit tests... > > This patch series doesn't add any. Yep. If you want to standardize on gtest, you get to convert or remove the existing tests. Until then, we use what we have. > It just adds some build system > glue so "make check" runs the existing stuff. Running self-tests shouldn't be made any harder than that.