All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org,
	stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255
Date: Thu, 05 Jul 2012 18:39:20 +0200	[thread overview]
Message-ID: <m3a9ze17t3.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <m3d34a41t0.fsf@blackfin.pond.sub.org> (Markus Armbruster's message of "Thu, 05 Jul 2012 18:20:43 +0200")

Markus Armbruster <armbru@redhat.com> writes:

> Kevin Wolf <kwolf@redhat.com> writes:
>
>> Am 29.06.2012 17:34, schrieb Markus Armbruster:
>>> New limits straight from ATA4 6.2 Register delivered data transfer
>>> command sector addressing.
>>> 
>>> I figure the old sector limit 63 was blindly copied from the BIOS
>>> int 13 limit.  Doesn't apply to the hardware.  No idea where the old
>>> cylinder limit comes from.
>>> 
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>> Now I think we have the very same thing in IDE, SCSI and virtio-blk.
>> Would it make sense to have a helper function in hd-geometry.c that
>> takes and validates the geometry from a BlockConf, applies defaults and
>> puts the result into device state fields passed by reference?
>
> I can look into this, but I'm afraid we'd need two helpers, because of
> IDE complications.

I'd like to try this in a follow-up series, together with a few more
cleanups made possible by this series.  Okay?

[...]

  reply	other threads:[~2012-07-05 16:39 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1340984094-5451-1-git-send-email-armbru@redhat.com>
     [not found] ` <1340984094-5451-19-git-send-email-armbru@redhat.com>
2012-07-02 12:55   ` [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf Stefan Hajnoczi
2012-07-02 13:07     ` Andreas Färber
2012-07-02 14:15       ` Markus Armbruster
2012-07-02 14:34         ` Stefan Hajnoczi
2012-07-03 19:11           ` Blue Swirl
2012-07-03 20:15             ` Andreas Färber
2012-07-04 16:19               ` Paolo Bonzini
2012-07-04 16:36                 ` Eric Blake
2012-07-05 18:37                   ` Blue Swirl
2012-07-05 18:30               ` Blue Swirl
     [not found] ` <1340984094-5451-9-git-send-email-armbru@redhat.com>
     [not found]   ` <CAAu8pHsKC6QMrhjUADiXT8DUrhy9HzbkN8pbYeWjM2aAE38ZwQ@mail.gmail.com>
     [not found]     ` <m3k3ypmjqu.fsf@blackfin.pond.sub.org>
2012-07-03 18:40       ` [Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c Blue Swirl
2012-07-04  8:24         ` Kevin Wolf
     [not found] ` <1340984094-5451-4-git-send-email-armbru@redhat.com>
     [not found]   ` <CAAu8pHtQORnuc2G8DiWTt1QcWOKbp7L8WJ=P7HMMZCNV7L-NRQ@mail.gmail.com>
2012-07-04 15:17     ` [Qemu-devel] [PATCH 03/32] vvfat: Fix partition table Kevin Wolf
2012-07-05  9:23       ` Markus Armbruster
2012-07-05  9:55         ` Kevin Wolf
2012-07-05 11:10           ` Markus Armbruster
2012-07-05 11:14             ` Kevin Wolf
     [not found] ` <1340984094-5451-5-git-send-email-armbru@redhat.com>
2012-07-04 15:23   ` [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry Kevin Wolf
2012-07-04 16:25     ` Paolo Bonzini
2012-07-05  7:06       ` Kevin Wolf
2012-07-05  9:16         ` Markus Armbruster
2012-07-05 11:13     ` Markus Armbruster
     [not found] ` <1340984094-5451-6-git-send-email-armbru@redhat.com>
2012-07-05  8:29   ` [Qemu-devel] [PATCH 05/32] qtest: Tidy up temporary files properly Kevin Wolf
2012-07-05  9:27     ` Markus Armbruster
     [not found] ` <1340984094-5451-14-git-send-email-armbru@redhat.com>
2012-07-05  9:16   ` [Qemu-devel] [PATCH 13/32] hd-geometry: Clean up confusing use of prior translation hint Kevin Wolf
2012-07-05  9:28     ` Markus Armbruster
     [not found] ` <1340984094-5451-23-git-send-email-armbru@redhat.com>
2012-07-05 11:33   ` [Qemu-devel] [PATCH 22/32] qtest: Cover qdev properties for disk geometry Kevin Wolf
2012-07-05 12:08     ` Markus Armbruster
     [not found] ` <1340984094-5451-33-git-send-email-armbru@redhat.com>
2012-07-05 15:27   ` [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255 Kevin Wolf
2012-07-05 16:20     ` Markus Armbruster
2012-07-05 16:39       ` Markus Armbruster [this message]
2012-07-06  8:50         ` Kevin Wolf
2012-07-11 13:10           ` Markus Armbruster
2012-07-06 14:50       ` Alexander Graf
2012-07-06 18:15         ` Markus Armbruster
2012-07-06  6:57 [Qemu-devel] [PATCH 00/32] Disk geometry cleanup Markus Armbruster
2012-07-06  6:58 ` [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255 Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3a9ze17t3.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.