From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmonX-0008Dk-RT for qemu-devel@nongnu.org; Thu, 05 Jul 2012 12:21:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmonS-0008Up-T7 for qemu-devel@nongnu.org; Thu, 05 Jul 2012 12:20:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmonS-0008UN-Ks for qemu-devel@nongnu.org; Thu, 05 Jul 2012 12:20:50 -0400 From: Markus Armbruster References: <1340984094-5451-1-git-send-email-armbru@redhat.com> <1340984094-5451-33-git-send-email-armbru@redhat.com> <4FF5B247.7070902@redhat.com> Date: Thu, 05 Jul 2012 18:20:43 +0200 In-Reply-To: <4FF5B247.7070902@redhat.com> (Kevin Wolf's message of "Thu, 05 Jul 2012 17:27:03 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org, Alexander Graf , pbonzini@redhat.com Kevin Wolf writes: > Am 29.06.2012 17:34, schrieb Markus Armbruster: >> New limits straight from ATA4 6.2 Register delivered data transfer >> command sector addressing. >> >> I figure the old sector limit 63 was blindly copied from the BIOS >> int 13 limit. Doesn't apply to the hardware. No idea where the old >> cylinder limit comes from. >> >> Signed-off-by: Markus Armbruster > > Now I think we have the very same thing in IDE, SCSI and virtio-blk. > Would it make sense to have a helper function in hd-geometry.c that > takes and validates the geometry from a BlockConf, applies defaults and > puts the result into device state fields passed by reference? I can look into this, but I'm afraid we'd need two helpers, because of IDE complications. When it comes to block device models, IDE is *always* the troublemaker. And a big reason for that is the messy data structures that are impractical to clean up while we still support non-qdevified IDE. Which we do almost three years after IDE qdevification. The laggards are: * mac99, g3beige Alexander Graf * spitz, borzoi, terrier Andrzej Zaborowski * tosa unmaintained * r2d Magnus Damm Any plans to drag these boards into the current decade already?