From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35849 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0uir-0004AB-6I for qemu-devel@nongnu.org; Wed, 29 Sep 2010 07:21:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0uim-0003LT-0r for qemu-devel@nongnu.org; Wed, 29 Sep 2010 07:21:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53557) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0uil-0003LJ-Qy for qemu-devel@nongnu.org; Wed, 29 Sep 2010 07:21:11 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 05/18] Monitor: Drop is_async_return() References: <1284668464-15981-1-git-send-email-lcapitulino@redhat.com> <1284668464-15981-6-git-send-email-lcapitulino@redhat.com> Date: Wed, 29 Sep 2010 13:21:08 +0200 In-Reply-To: <1284668464-15981-6-git-send-email-lcapitulino@redhat.com> (Luiz Capitulino's message of "Thu, 16 Sep 2010 17:20:51 -0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org Luiz Capitulino writes: > If I understood it correcty, the is_async_return() logic was only > used to prevent QMP from issuing duplicated success responses > for asynchronous handlers. > > However, QMP doesn't use do_info() anymore so this is dead logic > and (hopefully) can be safely dropped. Looks like it. Does anybody understand this async monitor stuff? It's used only for "info balloon" and "balloon". It keeps getting in the way. I'm sorely tempted to rip it out and reimplement it after we're done refactoring the monitor.