From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qz1s4-0001Hj-Gx for qemu-devel@nongnu.org; Thu, 01 Sep 2011 03:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qz1s3-0006IY-C6 for qemu-devel@nongnu.org; Thu, 01 Sep 2011 03:39:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qz1s3-0006IM-3a for qemu-devel@nongnu.org; Thu, 01 Sep 2011 03:39:31 -0400 From: Markus Armbruster References: <1314752751.84463.YahooMailClassic@web27003.mail.ukl.yahoo.com> <4E5D8BAA.9010302@codemonkey.ws> <4E5D9570.1030201@codemonkey.ws> <4E5E3789.3010603@codemonkey.ws> <4E5E39DF.3080609@codemonkey.ws> <4E5E4540.5030408@codemonkey.ws> <4E5E5BF3.50801@codemonkey.ws> Date: Thu, 01 Sep 2011 09:39:25 +0200 In-Reply-To: (Blue Swirl's message of "Wed, 31 Aug 2011 18:30:22 +0000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, bifferos Blue Swirl writes: > On Wed, Aug 31, 2011 at 4:06 PM, Anthony Liguori = wrote: >> On 08/31/2011 09:35 AM, malc wrote: >>> >>> On Wed, 31 Aug 2011, Anthony Liguori wrote: >>> >>>> Upper case field names are not okay. =C2=A0If you think coding style i= sn't >>>> clear, >>>> that's a bug in coding style. >>> >>> Sez hu? Coding style is garbage that should be thrown out of the window. >>> As for looking, yeah, i'm looking at usb with it's lovely hungarian >>> fields, should we stampede to "fix" it? >>> >>> If the one who's going to maintain the code is fine with whatever naming >>> is used so be it. >> >> No. =C2=A0That's how we got into the coding style mess we're in in the f= irst >> place. >> >> There's no benefit to going through and changing existing code but new c= ode >> needs to be consistent with the vast majority of code in the rest of the >> tree. =C2=A0It's about overall code base consistency and maintainability. > > I agree about importance of consistency, though I'd even go further > and reformat globally. New code gets introduced based on copying old > code so the pain goes on. If we reformat globally (big if), then we better reformat to a well-established style (such as linux kernel), not to this idiosyncratic QEMU-only style. Because the arguments about sharing and readability apply across projects, too.