From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752715AbcFALJG (ORCPT ); Wed, 1 Jun 2016 07:09:06 -0400 Received: from ni.piap.pl ([195.187.100.4]:42556 "EHLO ni.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbcFALJE convert rfc822-to-8bit (ORCPT ); Wed, 1 Jun 2016 07:09:04 -0400 From: khalasa@piap.pl (Krzysztof =?utf-8?Q?Ha=C5=82asa?=) To: Bjorn Helgaas Cc: Arnd Bergmann , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow" References: <20160531215802.30590.97398.stgit@bhelgaas-glaptop2.roam.corp.google.com> Date: Wed, 01 Jun 2016 13:08:59 +0200 In-Reply-To: <20160531215802.30590.97398.stgit@bhelgaas-glaptop2.roam.corp.google.com> (Bjorn Helgaas's message of "Tue, 31 May 2016 16:58:02 -0500") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 97367 [Jun 01 2016] X-KLMS-AntiSpam-Version: 5.5.9.33 X-KLMS-AntiSpam-Envelope-From: khalasa@piap.pl X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Moebius-Timestamps: 4158156, 4158202, 4158127 X-KLMS-AntiSpam-Info: LuaCore: 461 461 54b955193deae03de28a92c06fbe7c208d646055, Auth:dkim=none X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, 2016/05/30 14:24:18 X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, bases: 2016/06/01 07:13:00 #7499017 X-KLMS-AntiVirus-Status: Clean, skipped Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bjorn Helgaas writes: > This reverts commit 498a92d42596a7a32c042319eb62a4c3d8081cf1. > > Krzysztof reported that this change broke Cavium CNS3xxx, ARMv6 (Laguna > GW-2388) because the MRRS setting is never written to the hardware. > > Signed-off-by: Bjorn Helgaas > CC: Arnd Bergmann > CC: Krzysztof Hałasa > --- > arch/arm/mach-cns3xxx/pcie.c | 71 ++++++++++++++++++++++++------------------ > 1 file changed, 41 insertions(+), 30 deletions(-) This, applied to v4.7-rc1, fixes the problem on my Laguna boards. Tested-by: Krzysztof Hałasa And as well Acked-by: Krzysztof Hałasa Thanks. -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland