From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41093)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1RvQbv-0007Fk-OU
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 04:48:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1RvQbu-0004Tn-06
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 04:48:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56865)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1RvQbt-0004TY-Pn
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 04:48:13 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <4F324A60.7070600@samsung.com> <4F326D66.6060808@suse.de>
	<alpine.LNX.2.00.1202081903270.1498@linmac>
	<4F329385.4030203@codemonkey.ws>
Date: Thu, 09 Feb 2012 10:48:00 +0100
In-Reply-To: <4F329385.4030203@codemonkey.ws> (Anthony Liguori's message of
	"Wed, 08 Feb 2012 09:23:49 -0600")
Message-ID: <m3k43wcp7z.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] Restore consistent formatting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Evgeny Voevodin <e.voevodin@samsung.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Dmitry Solodkiy <d.solodkiy@samsung.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

Anthony Liguori <anthony@codemonkey.ws> writes:

> On 02/08/2012 09:04 AM, malc wrote:
>> On Wed, 8 Feb 2012, Andreas F?rber wrote:
>>
>>> malc,
>>>
>>> Arbitrarily reformatting your files is not okay. If you want a different
>>> formatting, you need to fix checkpatch.pl first to not error on that
>>> formatting in your files.
>>
>> It was always formatter like this (internally consistent), then others
>> added code which made it not so.
>
> We do have a mixed style in the audio layer.  I'm not happy about that
> but I also feel strongly that going through and doing a reformat is
> not a worthwhile exercise.
>
> I can also understand the desire to keep things consistent.  But
> patches should always go to the mailing list.  I certainly would have
> acked such a patch FWIW.

You buried the one truly important sentence, let me dig it out for you:

        *** Patches should always go to the mailing list ***

Exceptions need justification.  Responsible handling embargoed security
issues may qualify.  Style fixes certainly not.

[...]