From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52538)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QN3rJ-0001pO-K3
	for qemu-devel@nongnu.org; Thu, 19 May 2011 10:05:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QN3rD-0003w3-Eb
	for qemu-devel@nongnu.org; Thu, 19 May 2011 10:05:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40565)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QN3rD-0003vn-1z
	for qemu-devel@nongnu.org; Thu, 19 May 2011 10:05:43 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4JE5fiP017062
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 19 May 2011 10:05:42 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1305805037-17752-1-git-send-email-armbru@redhat.com>
	<1305805037-17752-4-git-send-email-armbru@redhat.com>
	<20110519131131.GB13222@amit-x200.redhat.com>
Date: Thu, 19 May 2011 16:05:39 +0200
In-Reply-To: <20110519131131.GB13222@amit-x200.redhat.com> (Amit Shah's
	message of "Thu, 19 May 2011 18:41:31 +0530")
Message-ID: <m3liy2kcp8.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any
	virtio-serial-bus device must have into bus props
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: alevy@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com

Amit Shah <amit.shah@redhat.com> writes:

> On (Thu) 19 May 2011 [13:37:16], Markus Armbruster wrote:
>> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
>> index bd3121e..a7d6b2b 100644
>> --- a/hw/virtio-serial-bus.c
>> +++ b/hw/virtio-serial-bus.c
>> @@ -642,6 +642,11 @@ static struct BusInfo virtser_bus_info = {
>>      .name      = "virtio-serial-bus",
>>      .size      = sizeof(VirtIOSerialBus),
>>      .print_dev = virtser_bus_dev_print,
>> +    .props      = (Property[]) {
>> +        DEFINE_PROP_UINT32("nr", VirtIOSerialPort, id, VIRTIO_CONSOLE_BAD_ID),
>> +        DEFINE_PROP_STRING("name", VirtIOSerialPort, name),
>> +        DEFINE_PROP_END_OF_LIST()
>> +    }
>
> 'name' isn't a must-have for all devices, but this is change OK.

The property is a must have, even though its value may remain null.
Correct?