From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QMb9M-0007vq-AH
	for qemu-devel@nongnu.org; Wed, 18 May 2011 03:26:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QMb9L-0004Ea-6s
	for qemu-devel@nongnu.org; Wed, 18 May 2011 03:26:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28509)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QMb9K-0004ER-Qt
	for qemu-devel@nongnu.org; Wed, 18 May 2011 03:26:31 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <20110506173224.278066589@linux.vnet.ibm.com>
	<20110506173245.282675435@linux.vnet.ibm.com>
Date: Wed, 18 May 2011 09:25:58 +0200
In-Reply-To: <20110506173245.282675435@linux.vnet.ibm.com> (Stefan Berger's
	message of "Fri, 06 May 2011 13:32:27 -0400")
Message-ID: <m3mxikjwqh.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH V4 03/10] Add persistent state handling to
	TPM TIS frontend driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: serge@hallyn.com, qemu-devel@nongnu.org, andreas.niederl@iaik.tugraz.at

Stefan Berger <stefanb@linux.vnet.ibm.com> writes:

> This patch adds support for handling of persistent state to the TPM TIS
> frontend.
>
> The currently used buffer is determined (can only be in currently active
> locality and either be a read or a write buffer) and only that buffer's content
> is stored. The reverse is done when the state is restored from disk
> where the buffer's content are copied into the currently used buffer.
>
> To keep compatibility with existing Xen the VMStateDescription was adapted
> to be compatible with existing state. For that I am adding Andreas
> Niederl as an author to the file.
>
> v4:
>  - main thread releases the 'state' lock while periodically calling the
>    backends function that may request it to write data into block storage.
>
> v3:
>  - all functions prefixed with tis_
>  - while the main thread is waiting for an outstanding TPM command to finish,
>    it periodically does some work (writes data to the block storage)
>
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>
> ---
>  hw/tpm_tis.c |  167 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 167 insertions(+)
>
> Index: qemu-git/hw/tpm_tis.c
> ===================================================================
> --- qemu-git.orig/hw/tpm_tis.c
> +++ qemu-git/hw/tpm_tis.c
[...]
> +static ISADeviceInfo tis_device_info = {
> +    .init         = tis_init,
> +    .qdev.name    = "tpm-tis",
> +    .qdev.size    = sizeof(TPMState),
> +    .qdev.no_user = 1,
> +    .qdev.vmsd    = &vmstate_tis,
> +    .qdev.reset   = tis_reset,
> +    .qdev.props = (Property[]) {
> +        DEFINE_PROP_UINT8("active_locality", TPMState,
> +                          active_locty, NO_LOCALITY),
> +        DEFINE_PROP_UINT32("irq", TPMState,
> +                           irq_num, TPM_TIS_IRQ),
> +        DEFINE_PROP_END_OF_LIST(),
> +    },
> +};
> +
> +
> +static void tis_register_device(void)
> +{
> +    isa_qdev_register(&tis_device_info);
> +}
> +
> +device_init(tis_register_device)

Why is this device no_user?