From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror) Date: Tue, 05 Jul 2011 08:15:46 +0200 Message-ID: References: <2cb2082c25eadc24d1e22ebbd4293e3e6b53c832.1309816302.git.rprabhu@wnohang.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, Raghavendra D Prabhu , kvm@vger.kernel.org To: Raghavendra D Prabhu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:30097 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753804Ab1GEGPx (ORCPT ); Tue, 5 Jul 2011 02:15:53 -0400 In-Reply-To: <2cb2082c25eadc24d1e22ebbd4293e3e6b53c832.1309816302.git.rprabhu@wnohang.net> (Raghavendra D. Prabhu's message of "Tue, 5 Jul 2011 03:30:02 +0530") Sender: kvm-owner@vger.kernel.org List-ID: Typo in subject: "unsed". The warning is spelled "unused-but-set-variable", the option "-Wunused-but-set-variable". Raghavendra D Prabhu writes: > In a few cases, variable attributed 'unused' has been added, in other cases > unused variable has been either removed or commented out. > > Signed-off-by: Raghavendra D Prabhu > --- > hw/device-assignment.c | 6 +++--- > simpletrace.c | 2 +- > xen-mapcache.c | 7 ++----- > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index 36ad6b0..19a59b4 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -1654,7 +1654,7 @@ static void reset_assigned_device(DeviceState *dev) > AssignedDevice *adev = DO_UPCAST(AssignedDevice, dev, pci_dev); > char reset_file[64]; > const char reset[] = "1"; > - int fd, ret; > + int fd, __attribute__((unused)) ret; > > snprintf(reset_file, sizeof(reset_file), > "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/reset", What about (void)write() and do away with ret? > @@ -1682,7 +1682,7 @@ static void reset_assigned_device(DeviceState *dev) > static int assigned_initfn(struct PCIDevice *pci_dev) > { > AssignedDevice *dev = DO_UPCAST(AssignedDevice, dev, pci_dev); > - uint8_t e_device, e_intx; > + uint8_t e_intx; > int r; > > if (!kvm_enabled()) { > @@ -1709,7 +1709,7 @@ static int assigned_initfn(struct PCIDevice *pci_dev) > goto out; > > /* handle interrupt routing */ > - e_device = (dev->dev.devfn >> 3) & 0x1f; > + /*e_device = (dev->dev.devfn >> 3) & 0x1f;*/ > e_intx = dev->dev.config[0x3d] - 1; > dev->intpin = e_intx; > dev->run = 0; > diff --git a/simpletrace.c b/simpletrace.c > index f1dbb5e..2ce9cff 100644 > --- a/simpletrace.c > +++ b/simpletrace.c > @@ -119,7 +119,7 @@ static void *writeout_thread(void *opaque) > TraceRecord record; > unsigned int writeout_idx = 0; > unsigned int num_available, idx; > - size_t unused; > + size_t __attribute__((unused)) unused; > > for (;;) { > wait_for_trace_records_available(); Same here. [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdyvK-000442-JA for qemu-devel@nongnu.org; Tue, 05 Jul 2011 02:15:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QdyvI-0003V2-W3 for qemu-devel@nongnu.org; Tue, 05 Jul 2011 02:15:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdyvI-0003Ux-Lm for qemu-devel@nongnu.org; Tue, 05 Jul 2011 02:15:52 -0400 From: Markus Armbruster References: <2cb2082c25eadc24d1e22ebbd4293e3e6b53c832.1309816302.git.rprabhu@wnohang.net> Date: Tue, 05 Jul 2011 08:15:46 +0200 In-Reply-To: <2cb2082c25eadc24d1e22ebbd4293e3e6b53c832.1309816302.git.rprabhu@wnohang.net> (Raghavendra D. Prabhu's message of "Tue, 5 Jul 2011 03:30:02 +0530") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Raghavendra D Prabhu Cc: Raghavendra D Prabhu , qemu-devel@nongnu.org, kvm@vger.kernel.org Typo in subject: "unsed". The warning is spelled "unused-but-set-variable", the option "-Wunused-but-set-variable". Raghavendra D Prabhu writes: > In a few cases, variable attributed 'unused' has been added, in other cases > unused variable has been either removed or commented out. > > Signed-off-by: Raghavendra D Prabhu > --- > hw/device-assignment.c | 6 +++--- > simpletrace.c | 2 +- > xen-mapcache.c | 7 ++----- > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index 36ad6b0..19a59b4 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -1654,7 +1654,7 @@ static void reset_assigned_device(DeviceState *dev) > AssignedDevice *adev = DO_UPCAST(AssignedDevice, dev, pci_dev); > char reset_file[64]; > const char reset[] = "1"; > - int fd, ret; > + int fd, __attribute__((unused)) ret; > > snprintf(reset_file, sizeof(reset_file), > "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/reset", What about (void)write() and do away with ret? > @@ -1682,7 +1682,7 @@ static void reset_assigned_device(DeviceState *dev) > static int assigned_initfn(struct PCIDevice *pci_dev) > { > AssignedDevice *dev = DO_UPCAST(AssignedDevice, dev, pci_dev); > - uint8_t e_device, e_intx; > + uint8_t e_intx; > int r; > > if (!kvm_enabled()) { > @@ -1709,7 +1709,7 @@ static int assigned_initfn(struct PCIDevice *pci_dev) > goto out; > > /* handle interrupt routing */ > - e_device = (dev->dev.devfn >> 3) & 0x1f; > + /*e_device = (dev->dev.devfn >> 3) & 0x1f;*/ > e_intx = dev->dev.config[0x3d] - 1; > dev->intpin = e_intx; > dev->run = 0; > diff --git a/simpletrace.c b/simpletrace.c > index f1dbb5e..2ce9cff 100644 > --- a/simpletrace.c > +++ b/simpletrace.c > @@ -119,7 +119,7 @@ static void *writeout_thread(void *opaque) > TraceRecord record; > unsigned int writeout_idx = 0; > unsigned int num_available, idx; > - size_t unused; > + size_t __attribute__((unused)) unused; > > for (;;) { > wait_for_trace_records_available(); Same here. [...]