From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPFmM-0004OQ-KT for qemu-devel@nongnu.org; Wed, 25 May 2011 11:13:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPFmK-0001uW-1G for qemu-devel@nongnu.org; Wed, 25 May 2011 11:13:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPFmJ-0001uL-Qo for qemu-devel@nongnu.org; Wed, 25 May 2011 11:13:43 -0400 From: Markus Armbruster References: <1306237507-19189-1-git-send-email-pbonzini@redhat.com> <1306237507-19189-4-git-send-email-pbonzini@redhat.com> <20110524221441.GB11809@yookeroo.fritz.box> Date: Wed, 25 May 2011 17:13:40 +0200 In-Reply-To: <20110524221441.GB11809@yookeroo.fritz.box> (David Gibson's message of "Wed, 25 May 2011 08:14:41 +1000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, agraf@suse.de David Gibson writes: > On Tue, May 24, 2011 at 01:45:07PM +0200, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> Cc: Alexander Graf >> Cc: David Gibson >> --- >> hw/spapr_vio.c | 8 +++++++- >> 1 files changed, 7 insertions(+), 1 deletions(-) >> >> diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c >> index be535d6..fee4c46 100644 >> --- a/hw/spapr_vio.c >> +++ b/hw/spapr_vio.c >> @@ -52,6 +52,10 @@ >> static struct BusInfo spapr_vio_bus_info = { >> .name = "spapr-vio", >> .size = sizeof(VIOsPAPRBus), >> + .props = (Property[]) { >> + DEFINE_PROP_UINT32("irq", VIOsPAPRDevice, vio_irq_num, 0), \ >> + DEFINE_PROP_END_OF_LIST(), >> + }, >> }; > > I don't see what the point of this is. Absolute irq numbers have no > special meaning in the XICS context, and the guest kernel will remap > them to virtual irqs anyway. Are the irq numbers guest-visible? If yes, a property may be required to keep them stable across migration. Especially when hot-plug comes into play. [...]