From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45014 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P0syj-00041Y-QU
	for qemu-devel@nongnu.org; Wed, 29 Sep 2010 05:29:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1P0sye-00027R-W3
	for qemu-devel@nongnu.org; Wed, 29 Sep 2010 05:29:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13107)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1P0sye-000277-Q4
	for qemu-devel@nongnu.org; Wed, 29 Sep 2010 05:29:28 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 01/18] Monitor: Introduce
	find_dispatch_table()
References: <1284668464-15981-1-git-send-email-lcapitulino@redhat.com>
	<1284668464-15981-2-git-send-email-lcapitulino@redhat.com>
Date: Wed, 29 Sep 2010 11:29:24 +0200
In-Reply-To: <1284668464-15981-2-git-send-email-lcapitulino@redhat.com> (Luiz
	Capitulino's message of "Thu, 16 Sep 2010 17:20:47 -0300")
Message-ID: <m3pqvwq4nf.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> writes:

> It's a generic version of monitor_find_command() which searches
> the dispatch table passed as an argument.
>
> Future commits will introduce new dispatch tables, so we need
> common code to search them.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  monitor.c |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index e602480..98fc57a 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3368,11 +3368,12 @@ static int is_valid_option(const char *c, const char *typestr)
>      return (typestr != NULL);
>  }
>  
> -static const mon_cmd_t *monitor_find_command(const char *cmdname)
> +static const mon_cmd_t *find_dispatch_table(const mon_cmd_t *disp_table,
> +                                            const char *cmdname)

find_dispatch_table() suggests it's searching for a dispatch table.
What about search_dispatch_table() or lookup_command()?

>  {
>      const mon_cmd_t *cmd;
>  
> -    for (cmd = mon_cmds; cmd->name != NULL; cmd++) {
> +    for (cmd = disp_table; cmd->name != NULL; cmd++) {
>          if (compare_cmd(cmdname, cmd->name)) {
>              return cmd;
>          }
> @@ -3381,6 +3382,11 @@ static const mon_cmd_t *monitor_find_command(const char *cmdname)
>      return NULL;
>  }
>  
> +static const mon_cmd_t *monitor_find_command(const char *cmdname)
> +{
> +    return find_dispatch_table(mon_cmds, cmdname);
> +}
> +
>  static const mon_cmd_t *monitor_parse_command(Monitor *mon,
>                                                const char *cmdline,
>                                                QDict *qdict)