From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vincent Bernat <vincent@bernat.im>
Subject: Re: [PATCH iproute2-next] ipaddress: fix label matching
Date: Sat, 14 Jul 2018 20:58:46 +0200
Message-ID: <m3r2k5skyh.fsf@luffy.cx>
References: <20180711113603.16589-1-vincent@bernat.im>
        <18bed3ed-4ad1-4506-6b80-62af9bd9e6d2@gmail.com>
        <m3sh4p3uto.fsf@luffy.cx>
        <057043f9-e476-cde8-4915-8e350fc6d848@gmail.com>
        <0b8902b1-fad1-55ef-acfc-088edb4569c6@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org,
        stephen@networkplumber.org
To: Serhey Popovych <serhe.popovych@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from bart.luffy.cx ([78.47.78.131]:47578 "EHLO bart.luffy.cx"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726960AbeGNTSs (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 14 Jul 2018 15:18:48 -0400
In-Reply-To: <0b8902b1-fad1-55ef-acfc-088edb4569c6@gmail.com> (Serhey
        Popovych's message of "Sat, 14 Jul 2018 21:54:07 +0300")
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

 =E2=9D=A6 14 juillet 2018 21:54 +0300, Serhey Popovych <serhe.popovych@gma=
il.com>=C2=A0:

> We should leave only filter.label check and return 0:
>
>     if (filter.label)
>             return 0;
>
> This will ensure we exit from print_linkinfo() earlier, skip
> print_link_stats() and push final filtering by label to
> print_selected_addrinfo() and print_addrinfo().
>
> And finally: this is regression and should be against iproute2, not -next.

As you did the analysis, I let you do the patch.
--=20
Watch out for off-by-one errors.
            - The Elements of Programming Style (Kernighan & Plauger)