From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vincent Bernat <vincent@bernat.im>
Subject: Re: [PATCH iproute2-next] ipaddress: fix label matching
Date: Thu, 12 Jul 2018 07:08:03 +0200
Message-ID: <m3sh4p3uto.fsf@luffy.cx>
References: <20180711113603.16589-1-vincent@bernat.im>
        <18bed3ed-4ad1-4506-6b80-62af9bd9e6d2@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
        serhe.popovych@gmail.com
To: David Ahern <dsahern@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from bart.luffy.cx ([78.47.78.131]:34538 "EHLO bart.luffy.cx"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725786AbeGLFP4 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 12 Jul 2018 01:15:56 -0400
In-Reply-To: <18bed3ed-4ad1-4506-6b80-62af9bd9e6d2@gmail.com> (David Ahern's
        message of "Wed, 11 Jul 2018 21:01:19 -0400")
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

 =E2=9D=A6 11 juillet 2018 21:01 -0400, David Ahern <dsahern@gmail.com>=C2=
=A0:

>> +++ b/ip/ipaddress.c
>> @@ -837,11 +837,6 @@ int print_linkinfo(const struct sockaddr_nl *who,
>>  	if (!name)
>>  		return -1;
>>=20=20
>> -	if (filter.label &&
>> -	    (!filter.family || filter.family =3D=3D AF_PACKET) &&
>> -	    fnmatch(filter.label, name, 0))
>> -		return -1;
>> -
>
> The offending commit changed the return code:
>
>         if (filter.label &&
>             (!filter.family || filter.family =3D=3D AF_PACKET) &&
> -           fnmatch(filter.label, RTA_DATA(tb[IFLA_IFNAME]), 0))
> -               return 0;
> +           fnmatch(filter.label, name, 0))
> +               return -1;
>
>
> Vincent: can you try leaving the code as is, but change the return to 0?

Yes, it works by just returning 0. The code still doesn't make sense.
--=20
Many pages make a thick book, except for pocket Bibles which are on very
very thin paper.