From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stewart Smith Subject: Re: [PATCH v2 2/2] leds/powernv: Add driver for PowerNV platform Date: Wed, 22 Apr 2015 09:03:36 +1000 Message-ID: References: <20150320105921.14866.83209.stgit@localhost.localdomain> <20150320110328.14866.98225.stgit@localhost.localdomain> <552D303A.5080506@samsung.com> <552F437E.4020409@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from e39.co.us.ibm.com ([32.97.110.160]:42353 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964934AbbDUXDo (ORCPT ); Tue, 21 Apr 2015 19:03:44 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Apr 2015 17:03:43 -0600 Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id C1890C9003E for ; Tue, 21 Apr 2015 18:54:48 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t3LN3daG65536154 for ; Tue, 21 Apr 2015 23:03:39 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t3LN3cNs027265 for ; Tue, 21 Apr 2015 19:03:39 -0400 In-Reply-To: <552F437E.4020409@linux.vnet.ibm.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: mpe@ellerman.id.au Cc: Vasant Hegde , Jacek Anaszewski , linuxppc-dev@lists.ozlabs.org, linux-leds@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, khandual@linux.vnet.ibm.com Vasant Hegde writes: > On 04/16/2015 12:20 AM, Stewart Smith wrote: >> Jacek Anaszewski writes: >>>> +static struct platform_driver powernv_led_driver = { >>>> + .probe = powernv_led_probe, >>>> + .remove = powernv_led_remove, >>>> + .driver = { >>>> + .name = "powernv-led-driver", >>>> + .owner = THIS_MODULE, >>>> + .of_match_table = powernv_led_match, >>> >>> Is somewhere DT documentation available for these leds? >> >> https://github.com/open-power/skiboot/blob/master/doc/device-tree/ibm%2Copal/led.txt >> >> We've been documenting things in firmware source, and I'm open to if we >> should mirror this somewhere (somewhere in linux Documentation/ ?). > > Stewart, > > I'm adding Documentation/devicetree/bindings/leds/leds-powernv.txt ...which is > pretty much similar to the device tree documentation we have in OPAL side. Michael, I know we've kind of discussed this in the past, but perhaps we should come up with a conistent way of doing this for OPAL related docs. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e7.ny.us.ibm.com (e7.ny.us.ibm.com [32.97.182.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 5D2AD1A0245 for ; Wed, 22 Apr 2015 09:03:45 +1000 (AEST) Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Apr 2015 19:03:41 -0400 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 8CD8738C8041 for ; Tue, 21 Apr 2015 19:03:39 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t3LN3dkH58392582 for ; Tue, 21 Apr 2015 23:03:39 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t3LN3cNm027265 for ; Tue, 21 Apr 2015 19:03:39 -0400 From: Stewart Smith To: mpe@ellerman.id.au Subject: Re: [PATCH v2 2/2] leds/powernv: Add driver for PowerNV platform In-Reply-To: <552F437E.4020409@linux.vnet.ibm.com> References: <20150320105921.14866.83209.stgit@localhost.localdomain> <20150320110328.14866.98225.stgit@localhost.localdomain> <552D303A.5080506@samsung.com> <552F437E.4020409@linux.vnet.ibm.com> Date: Wed, 22 Apr 2015 09:03:36 +1000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: cooloney@gmail.com, Vasant Hegde , rpurdie@rpsys.net, linuxppc-dev@lists.ozlabs.org, Jacek Anaszewski , linux-leds@vger.kernel.org, khandual@linux.vnet.ibm.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Vasant Hegde writes: > On 04/16/2015 12:20 AM, Stewart Smith wrote: >> Jacek Anaszewski writes: >>>> +static struct platform_driver powernv_led_driver = { >>>> + .probe = powernv_led_probe, >>>> + .remove = powernv_led_remove, >>>> + .driver = { >>>> + .name = "powernv-led-driver", >>>> + .owner = THIS_MODULE, >>>> + .of_match_table = powernv_led_match, >>> >>> Is somewhere DT documentation available for these leds? >> >> https://github.com/open-power/skiboot/blob/master/doc/device-tree/ibm%2Copal/led.txt >> >> We've been documenting things in firmware source, and I'm open to if we >> should mirror this somewhere (somewhere in linux Documentation/ ?). > > Stewart, > > I'm adding Documentation/devicetree/bindings/leds/leds-powernv.txt ...which is > pretty much similar to the device tree documentation we have in OPAL side. Michael, I know we've kind of discussed this in the past, but perhaps we should come up with a conistent way of doing this for OPAL related docs.