From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754715AbbAVWfl (ORCPT ); Thu, 22 Jan 2015 17:35:41 -0500 Received: from e9.ny.us.ibm.com ([32.97.182.139]:56812 "EHLO e9.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753501AbbAVWfj (ORCPT ); Thu, 22 Jan 2015 17:35:39 -0500 From: Stewart Smith To: Pranith Kumar , Michael Ellerman Cc: Rob Herring , open list , Vasant Hegde , Paul Mackerras , Joel Stanley , Mahesh Salgaonkar , Neelesh Gupta , "open list\:LINUX FOR POWERPC..." , Anton Blanchard Subject: Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n In-Reply-To: References: <1421893570-6920-1-git-send-email-bobby.prani@gmail.com> <1421893570-6920-2-git-send-email-bobby.prani@gmail.com> <1421903958.4598.4.camel@ellerman.id.au> User-Agent: Notmuch/0.18+16~gec02089 (http://notmuchmail.org) Emacs/23.1.1 (x86_64-redhat-linux-gnu) Date: Fri, 23 Jan 2015 09:35:28 +1100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15012222-0033-0000-0000-000001A554DF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pranith Kumar writes: > On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman wrote: >> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote: >>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get() >>> return 0. Check for these return values and skip registering the dump buffer. >>> >>> Signed-off-by: Pranith Kumar >>> CC: Michael Ellerman >>> --- >>> arch/powerpc/platforms/powernv/opal.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >> >> What changed since v1? I don't see anything? >> > > Nothing in this patch but there is a v2 of the first patch in this > series, so had to resend this patch with a v2. You also missed my Reviewed-by :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e8.ny.us.ibm.com (e8.ny.us.ibm.com [32.97.182.138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 914531A0E52 for ; Fri, 23 Jan 2015 09:35:40 +1100 (AEDT) Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Jan 2015 17:35:38 -0500 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 0BD716E8045 for ; Thu, 22 Jan 2015 17:27:28 -0500 (EST) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t0MMZZuZ26804454 for ; Thu, 22 Jan 2015 22:35:35 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t0MMZYvP029586 for ; Thu, 22 Jan 2015 17:35:34 -0500 From: Stewart Smith To: Pranith Kumar , Michael Ellerman Subject: Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n In-Reply-To: References: <1421893570-6920-1-git-send-email-bobby.prani@gmail.com> <1421893570-6920-2-git-send-email-bobby.prani@gmail.com> <1421903958.4598.4.camel@ellerman.id.au> Date: Fri, 23 Jan 2015 09:35:28 +1100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Rob Herring , Mahesh Salgaonkar , open list , Vasant Hegde , Paul Mackerras , Joel Stanley , Neelesh Gupta , "open list:LINUX FOR POWERPC..." , Anton Blanchard List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Pranith Kumar writes: > On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman wrote: >> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote: >>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get() >>> return 0. Check for these return values and skip registering the dump buffer. >>> >>> Signed-off-by: Pranith Kumar >>> CC: Michael Ellerman >>> --- >>> arch/powerpc/platforms/powernv/opal.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >> >> What changed since v1? I don't see anything? >> > > Nothing in this patch but there is a v2 of the first patch in this > series, so had to resend this patch with a v2. You also missed my Reviewed-by :)