From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40791 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P0v27-0007Bw-Vr
	for qemu-devel@nongnu.org; Wed, 29 Sep 2010 07:41:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1P0v22-0006Md-Kv
	for qemu-devel@nongnu.org; Wed, 29 Sep 2010 07:41:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34160)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1P0v22-0006MT-D3
	for qemu-devel@nongnu.org; Wed, 29 Sep 2010 07:41:06 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 00/18] Monitor: split HMP and QMP dispatch
	tables
References: <1284668464-15981-1-git-send-email-lcapitulino@redhat.com>
	<4C98AB70.2000005@codemonkey.ws>
Date: Wed, 29 Sep 2010 13:41:01 +0200
In-Reply-To: <4C98AB70.2000005@codemonkey.ws> (Anthony Liguori's message of
	"Tue, 21 Sep 2010 07:56:16 -0500")
Message-ID: <m3sk0sojzm.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

Anthony Liguori <anthony@codemonkey.ws> writes:

> On 09/16/2010 03:20 PM, Luiz Capitulino wrote:
>> The subject says it all: with this series applied we'll get different
>> dispatch tables for HMP and QMP, which has the side effect of making
>> QMP commands (such as qmp_capabilities) disappear from HMP's scope.
>>
>> This is also the beginning of the Monitor's redesign, which aims to
>> separate QMP, HMP and common code.
>>
>> There's a penalty, though. We're going to get a bit of duplication
>> during the process, like duplicated handlers entries in the
>> dispatch tables.
>>
>> We'll need more separation and a proper internal QMP interface to
>> solve that...
>>    
>
> Acked-by: Anthony Liguori <aliguori@us.ibm.com>
>
> It all looks pretty straight forward.  Nice work!

Agree.