From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NuAJr-0000uE-Hv
	for qemu-devel@nongnu.org; Tue, 23 Mar 2010 16:03:19 -0400
Received: from [140.186.70.92] (port=37712 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NuAJp-0000su-P2
	for qemu-devel@nongnu.org; Tue, 23 Mar 2010 16:03:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1NuAJn-0000hd-UR
	for qemu-devel@nongnu.org; Tue, 23 Mar 2010 16:03:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54077)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1NuAJn-0000hM-Ly
	for qemu-devel@nongnu.org; Tue, 23 Mar 2010 16:03:15 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] git head broken? (x86 softmmu w/o kvm)
References: <20100322212524.GA75169@triton8.kn-bremen.de>
	<20100323022726.GB14049@hall.aurel32.net>
	<20100323090344.GA28611@volta.aurel32.net>
	<f43fc5581003231224q32ac024dsad421fb10869f5fe@mail.gmail.com>
	<4BA9199E.1080206@codemonkey.ws>
Date: Tue, 23 Mar 2010 21:02:50 +0100
In-Reply-To: <4BA9199E.1080206@codemonkey.ws> (Anthony Liguori's message of
	"Tue, 23 Mar 2010 14:42:22 -0500")
Message-ID: <m3tys63ixh.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, Juergen Lock <nox@jelal.kn-bremen.de>, Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org

Anthony Liguori <anthony@codemonkey.ws> writes:

> Hi,
>
> On 03/23/2010 02:24 PM, Blue Swirl wrote:
>> On 3/23/10, Aurelien Jarno<aurelien@aurel32.net>  wrote:
>>    
>>> On Tue, Mar 23, 2010 at 03:27:26AM +0100, Aurelien Jarno wrote:
>>>   >  On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote:
>>>   >  >  Hi!
>>>   >  >
>>>   >  >   I just wanted to make another FreeBSD qemu git head snaphot port update,
>>>   >  >  and found both i386-softmmu and x86_64-softmmu no longer boot, they seem
>>>   >  >  to hang early in the bios before it prints anything, last tb seems to be
>>>   >  >  this loop:
>>>   >  >
>>>   >
>>>   >  A quick bisect revealed it has been broken by this patch:
>>>   >
>>>
>>>
>>> I have just pushed a patch to fix the problem.
>>>      
>> Thanks, sorry for the trouble.
>>    
>
> It would be nice to send a series like this to the list first in the
> future to give people a heads up.  It's a useful set of clean-ups but
> it's nice to give people a chance to provide input.

It's not merely "nice", it's how we work.  It's a far more important and
useful rule than where to put the curlies and such.

And yes, the patch series is good stuff.