From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59746)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Soy0j-0006W9-Qh
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:35:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Soy0Z-00078Q-TG
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:35:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60616)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Soy0Z-000785-Ly
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:35:15 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1341911575-7306-1-git-send-email-armbru@redhat.com>
	<1341911575-7306-6-git-send-email-armbru@redhat.com>
	<4FFD8595.1060505@redhat.com>
Date: Wed, 11 Jul 2012 16:35:10 +0200
In-Reply-To: <4FFD8595.1060505@redhat.com> (Kevin Wolf's message of "Wed, 11
	Jul 2012 15:54:29 +0200")
Message-ID: <m3vchu5psx.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry
	guessing back from block.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: blauwirbel@gmail.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

Kevin Wolf <kwolf@redhat.com> writes:

> Am 10.07.2012 11:12, schrieb Markus Armbruster:
>> Commit f3d54fc4 factored it out of hw/ide.c for reuse.  Sensible,
>> except it was put into block.c.  Device-specific functionality should
>> be kept in device code, not the block layer.  Move it to
>> hw/hd-geometry.c, and make stylistic changes required to keep
>> checkpatch.pl happy.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  block.c           |  121 ---------------------------------------
>>  block.h           |    1 -
>>  blockdev.h        |    1 +
>>  hw/Makefile.objs  |    2 +-
>>  hw/block-common.h |   21 +++++++
>>  hw/hd-geometry.c  |  162 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  hw/ide/core.c     |    3 +-
>>  hw/scsi-disk.c    |    5 +-
>>  hw/virtio-blk.c   |    3 +-
>>  9 files changed, 192 insertions(+), 127 deletions(-)
>>  create mode 100644 hw/block-common.h
>>  create mode 100644 hw/hd-geometry.c
>
>> diff --git a/blockdev.h b/blockdev.h
>> index 260e16b..26454c9 100644
>> --- a/blockdev.h
>> +++ b/blockdev.h
>> @@ -62,4 +62,5 @@ void qmp_change_blockdev(const char *device, const char *filename,
>>                           bool has_format, const char *format, Error **errp);
>>  void do_commit(Monitor *mon, const QDict *qdict);
>>  int do_drive_del(Monitor *mon, const QDict *qdict, QObject **ret_data);
>> +
>>  #endif
>
> Any objections against dropping this hunk before applying?
>
> Kevin

Nope.