From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754669AbbA2G0Y (ORCPT ); Thu, 29 Jan 2015 01:26:24 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:49197 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752578AbbA2G0W (ORCPT ); Thu, 29 Jan 2015 01:26:22 -0500 From: Stewart Smith To: Preeti U Murthy , mpe@ellerman.id.au Cc: rafael.j.wysocki@intel.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH V2] cpuidle/powernv: Read target_residency value of idle states from DT if available In-Reply-To: <20150128021044.11166.81418.stgit@preeti.in.ibm.com> References: <20150128021044.11166.81418.stgit@preeti.in.ibm.com> User-Agent: Notmuch/0.18+16~gec02089 (http://notmuchmail.org) Emacs/23.1.1 (x86_64-redhat-linux-gnu) Date: Wed, 28 Jan 2015 20:15:28 +1100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15012809-0033-0000-0000-0000037B0238 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Preeti U Murthy writes: > The device tree now exposes the residency values for different idle states. Read > these values instead of calculating residency from the latency values. The values > exposed in the DT are validated for optimal power efficiency. However to maintain > compatibility with the older firmware code which does not expose residency > values, use default values as a fallback mechanism. While at it, handle some > cleanups. >>From a "I just merged the patch that exports these values from firmware" point of view, using them and falling back looks good. (I find the hardcoding of snooze in the driver a bit odd, as is the hardcoding of max power states to 8 - which could bite us in the future if a future processor has more states... but these aren't problems with this patch) Acked-by: Stewart Smith From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stewart Smith Subject: Re: [PATCH V2] cpuidle/powernv: Read target_residency value of idle states from DT if available Date: Wed, 28 Jan 2015 20:15:28 +1100 Message-ID: References: <20150128021044.11166.81418.stgit@preeti.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150128021044.11166.81418.stgit@preeti.in.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Preeti U Murthy , mpe@ellerman.id.au Cc: rafael.j.wysocki@intel.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org List-Id: linux-pm@vger.kernel.org UHJlZXRpIFUgTXVydGh5IDxwcmVldGlAbGludXgudm5ldC5pYm0uY29tPiB3cml0ZXM6Cj4gVGhl IGRldmljZSB0cmVlIG5vdyBleHBvc2VzIHRoZSByZXNpZGVuY3kgdmFsdWVzIGZvciBkaWZmZXJl bnQgaWRsZSBzdGF0ZXMuIFJlYWQKPiB0aGVzZSB2YWx1ZXMgaW5zdGVhZCBvZiBjYWxjdWxhdGlu ZyByZXNpZGVuY3kgZnJvbSB0aGUgbGF0ZW5jeSB2YWx1ZXMuIFRoZSB2YWx1ZXMKPiBleHBvc2Vk IGluIHRoZSBEVCBhcmUgdmFsaWRhdGVkIGZvciBvcHRpbWFsIHBvd2VyIGVmZmljaWVuY3kuIEhv d2V2ZXIgdG8gbWFpbnRhaW4KPiBjb21wYXRpYmlsaXR5IHdpdGggdGhlIG9sZGVyIGZpcm13YXJl IGNvZGUgd2hpY2ggZG9lcyBub3QgZXhwb3NlIHJlc2lkZW5jeQo+IHZhbHVlcywgdXNlIGRlZmF1 bHQgdmFsdWVzIGFzIGEgZmFsbGJhY2sgbWVjaGFuaXNtLiBXaGlsZSBhdCBpdCwgaGFuZGxlIHNv bWUKPiBjbGVhbnVwcy4KCkZyb20gYSAiSSBqdXN0IG1lcmdlZCB0aGUgcGF0Y2ggdGhhdCBleHBv cnRzIHRoZXNlIHZhbHVlcyBmcm9tIGZpcm13YXJlIgpwb2ludCBvZiB2aWV3LCB1c2luZyB0aGVt IGFuZCBmYWxsaW5nIGJhY2sgbG9va3MgZ29vZC4KCihJIGZpbmQgdGhlIGhhcmRjb2Rpbmcgb2Yg c25vb3plIGluIHRoZSBkcml2ZXIgYSBiaXQgb2RkLCBhcyBpcyB0aGUKaGFyZGNvZGluZyBvZiBt YXggcG93ZXIgc3RhdGVzIHRvIDggLSB3aGljaCBjb3VsZCBiaXRlIHVzIGluIHRoZSBmdXR1cmUK aWYgYSBmdXR1cmUgcHJvY2Vzc29yIGhhcyBtb3JlIHN0YXRlcy4uLiBidXQgdGhlc2UgYXJlbid0 IHByb2JsZW1zIHdpdGgKdGhpcyBwYXRjaCkKCkFja2VkLWJ5OiBTdGV3YXJ0IFNtaXRoIDxzdGV3 YXJ0QGxpbnV4LnZuZXQuaWJtLmNvbT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkxpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QKTGludXhwcGMtZGV2QGxp c3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2xpbnV4cHBj LWRldg==