From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46386)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SlhPL-000560-El
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 10:15:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SlhPF-0006iT-0t
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 10:15:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32587)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SlhPE-0006iC-PL
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 10:15:12 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1340984094-5451-1-git-send-email-armbru@redhat.com>
	<1340984094-5451-19-git-send-email-armbru@redhat.com>
	<20120702125515.GA16482@stefanha-thinkpad.localdomain>
	<4FF19D21.20005@suse.de>
Date: Mon, 02 Jul 2012 16:15:08 +0200
In-Reply-To: <4FF19D21.20005@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22's?=
	message of "Mon, 02 Jul 2012 15:07:45 +0200")
Message-ID: <m3wr2m5jwz.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to
	match BlockConf
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>
Cc: kwolf@redhat.com, pbonzini@redhat.com, aliguori@us.ibm.com, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Andreas F=C3=A4rber <afaerber@suse.de> writes:

> Am 02.07.2012 14:55, schrieb Stefan Hajnoczi:
>> On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote:
>>> Best to use the same type, to avoid unwanted truncation or sign
>>> extension.
>>>
>>> BlockConf can't use plain int for cyls, heads and secs, because
>>> integer properties require an exact width.
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>> ---
>>>  blockdev.h       |    2 +-
>>>  hw/hd-geometry.c |    4 ++--
>>>  hw/ide/core.c    |    2 +-
>>>  hw/scsi-disk.c   |    2 +-
>>>  hw/virtio-blk.c  |    2 +-
>>>  5 files changed, 6 insertions(+), 6 deletions(-)
>>=20
>> It would be nice to update the hd_geometry_lchs_guess() trace event that
>> you added to use uint32_t + %u instead of int + %d.
>
> PRIu32?

uint32_t: Good point, will do.

Conversion specifier: trace-events routinely prints uint32_t with %d and
%x, never with PRI*32.  I'm happy to change from %d to %u, but reluctant
to add the first use of PRIu32.