From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5995FA3730 for ; Thu, 17 Oct 2019 09:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76622214E0 for ; Thu, 17 Oct 2019 09:46:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WuaWhX4a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439603AbfJQJqp (ORCPT ); Thu, 17 Oct 2019 05:46:45 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46585 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbfJQJqo (ORCPT ); Thu, 17 Oct 2019 05:46:44 -0400 Received: by mail-wr1-f65.google.com with SMTP id o18so1526600wrv.13; Thu, 17 Oct 2019 02:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=HKy0scgKD2Yqtf85mglqediv2brLo+GCB1Q93X6euAo=; b=WuaWhX4a2YttbDW1uaoNrQa8MGElT2XHF+EH1vrh+FhKdJ7zerR1iOBaQLR9V4And+ erCM0k4fsG6I7tXe/gPaplriKFpi/DpIms4+UWhyO2pqsec85FYZ7IV8Q/U9D7EZSpEd t0jAjzctzu/mzoif0XszF32ycjQ0+Nx0WpFXKbaDOIfwcWtyPV0ercNjE40OrDdqKyk0 pnOkfP29TCzKCCAo+9GQwF15UJ+hZ02YJ3UgvX/Rt8LB6aK+PeYivQUHZDhlHDY/eidf 82uy2VQ8ZWMCPe2sNLnAlOBcYmCOk8DP9tForqbHLWTLfhZVKYG7+m4Jsu5aiHRmkO7Y qOyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=HKy0scgKD2Yqtf85mglqediv2brLo+GCB1Q93X6euAo=; b=Klfd3UWZDrHsk2MV6fPNStIXBtgXKvGQJ4adyw3xhbdUXNnVx+q+exblCYpvjrgyuX 10IJwFqh1bhn7YpSAEBecBdTPyY630yyEptsGhUAXk1z03y+zn0MKCVT7Ml9uSxq/smW Oym+CrT6A4e+XsIVA2S4jLSmSo0jJbizKHLEgUZEO9Vth2z+DQOHnu53WeZTp1jQ9HA6 nNvbpvi1nadDzZ5bgMe1NMZPjvdLYXRlaFqcq/qHizqBGlZN1bjXuFnCIAPQirlC6ZIj Zr+0IMM5eKMc+D20tuvoIf1GqCOK47AwrU0lKm7MwipO4wFFM9gCTeLThj/0OTuR8Zax IxtA== X-Gm-Message-State: APjAAAWL6ZsRM/e4eiG9u1xE82Ph+euxUGO+oSdTUmaSgtjy/mT5O4Oo AbXBbd0wuo7zE9lPLPrU78p2qKJBbcU= X-Google-Smtp-Source: APXvYqxrXHe+FRRJ2WwWs57//iOV5M+rIWiIDpk9WzExeUemaBkFY9x6xk6p7+jfLAgGOzcY00CGjQ== X-Received: by 2002:adf:f547:: with SMTP id j7mr2346059wrp.26.1571305601811; Thu, 17 Oct 2019 02:46:41 -0700 (PDT) Received: from arch-late (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id w17sm1678983wra.34.2019.10.17.02.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 02:46:41 -0700 (PDT) References: <20191015135915.6530-1-hslester96@gmail.com> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Rui Miguel Silva To: Chuhong Yuan Cc: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get In-reply-to: <20191015135915.6530-1-hslester96@gmail.com> Date: Thu, 17 Oct 2019 10:46:38 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chuhong, many thanks for the patch. On Tue 15 Oct 2019 at 14:59, Chuhong Yuan wrote: > devm_regulator_get may return an error but mipi_csis_phy_init misses > a check for it. > This may lead to problems when regulator_set_voltage uses the unchecked > pointer. > This patch adds a check for devm_regulator_get to avoid potential risk. > > Signed-off-by: Chuhong Yuan Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- > Changes in v2: > - Add a check in mipi_csis_probe for the modified mipi_csis_phy_init. > > drivers/staging/media/imx/imx7-mipi-csis.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 73d8354e618c..e8a6acaa969e 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -350,6 +350,8 @@ static void mipi_csis_sw_reset(struct csi_state *state) > static int mipi_csis_phy_init(struct csi_state *state) > { > state->mipi_phy_regulator = devm_regulator_get(state->dev, "phy"); > + if (IS_ERR(state->mipi_phy_regulator)) > + return PTR_ERR(state->mipi_phy_regulator); > > return regulator_set_voltage(state->mipi_phy_regulator, 1000000, > 1000000); > @@ -966,7 +968,10 @@ static int mipi_csis_probe(struct platform_device *pdev) > return ret; > } > > - mipi_csis_phy_init(state); > + ret = mipi_csis_phy_init(state); > + if (ret < 0) > + return ret; > + > mipi_csis_phy_reset(state); > > mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC4BFA3732 for ; Thu, 17 Oct 2019 09:46:47 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0AF021848 for ; Thu, 17 Oct 2019 09:46:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WuaWhX4a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0AF021848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id C786723E6B; Thu, 17 Oct 2019 09:46:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YpQnB+WJ8RAc; Thu, 17 Oct 2019 09:46:45 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 7A3262046F; Thu, 17 Oct 2019 09:46:45 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 576ED1BF2CF for ; Thu, 17 Oct 2019 09:46:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 4789986D73 for ; Thu, 17 Oct 2019 09:46:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id seNlr6cXo8Ri for ; Thu, 17 Oct 2019 09:46:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by hemlock.osuosl.org (Postfix) with ESMTPS id 6B00B86D42 for ; Thu, 17 Oct 2019 09:46:43 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id z9so1535670wrl.11 for ; Thu, 17 Oct 2019 02:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=HKy0scgKD2Yqtf85mglqediv2brLo+GCB1Q93X6euAo=; b=WuaWhX4a2YttbDW1uaoNrQa8MGElT2XHF+EH1vrh+FhKdJ7zerR1iOBaQLR9V4And+ erCM0k4fsG6I7tXe/gPaplriKFpi/DpIms4+UWhyO2pqsec85FYZ7IV8Q/U9D7EZSpEd t0jAjzctzu/mzoif0XszF32ycjQ0+Nx0WpFXKbaDOIfwcWtyPV0ercNjE40OrDdqKyk0 pnOkfP29TCzKCCAo+9GQwF15UJ+hZ02YJ3UgvX/Rt8LB6aK+PeYivQUHZDhlHDY/eidf 82uy2VQ8ZWMCPe2sNLnAlOBcYmCOk8DP9tForqbHLWTLfhZVKYG7+m4Jsu5aiHRmkO7Y qOyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=HKy0scgKD2Yqtf85mglqediv2brLo+GCB1Q93X6euAo=; b=hCkYsItlsLNQZllzEY4Iel8sePz//l0kHHGy9fuyPUZTzfTHMUhVjU5wL/fOb1NVv6 Z+5Jll5xPzAcM52ZSYWIGurKI1NucVeSrOPYpp0N78XuQB+CWTJj5OQ0ewICB0OpGO7Y MdKFml8p5u6+tehefoUhlSpm7yFgsa3oTky8j3rmlB4u103PFU/GeH+Drev2QK86bMgE 91chcwOzNxJsl5dihp1fT6VyxW6VohMhLF1vi4pt3uaun3H+hKpbVJGn7EKG6A8dsKkP 5ChS+tIZkAQzDEBwDsezeDJfX7xraq+VFGjH8vN7rZC2cXZaFeoIq2IS+0efmHPClpZ6 3Rkg== X-Gm-Message-State: APjAAAU5AgRvsJcY0K7ZgY60xpXybsUb6BWEHG8C6gcakXQBMihwKWOS 4VGphi53kY8kQGlQNwOl5Ws= X-Google-Smtp-Source: APXvYqxrXHe+FRRJ2WwWs57//iOV5M+rIWiIDpk9WzExeUemaBkFY9x6xk6p7+jfLAgGOzcY00CGjQ== X-Received: by 2002:adf:f547:: with SMTP id j7mr2346059wrp.26.1571305601811; Thu, 17 Oct 2019 02:46:41 -0700 (PDT) Received: from arch-late (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id w17sm1678983wra.34.2019.10.17.02.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 02:46:41 -0700 (PDT) References: <20191015135915.6530-1-hslester96@gmail.com> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Rui Miguel Silva To: Chuhong Yuan Subject: Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get In-reply-to: <20191015135915.6530-1-hslester96@gmail.com> Date: Thu, 17 Oct 2019 10:46:38 +0100 Message-ID: MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Pengutronix Kernel Team , Greg Kroah-Hartman , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Philipp Zabel , Steve Longerbeam , Mauro Carvalho Chehab , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Chuhong, many thanks for the patch. On Tue 15 Oct 2019 at 14:59, Chuhong Yuan wrote: > devm_regulator_get may return an error but mipi_csis_phy_init misses > a check for it. > This may lead to problems when regulator_set_voltage uses the unchecked > pointer. > This patch adds a check for devm_regulator_get to avoid potential risk. > > Signed-off-by: Chuhong Yuan Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- > Changes in v2: > - Add a check in mipi_csis_probe for the modified mipi_csis_phy_init. > > drivers/staging/media/imx/imx7-mipi-csis.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 73d8354e618c..e8a6acaa969e 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -350,6 +350,8 @@ static void mipi_csis_sw_reset(struct csi_state *state) > static int mipi_csis_phy_init(struct csi_state *state) > { > state->mipi_phy_regulator = devm_regulator_get(state->dev, "phy"); > + if (IS_ERR(state->mipi_phy_regulator)) > + return PTR_ERR(state->mipi_phy_regulator); > > return regulator_set_voltage(state->mipi_phy_regulator, 1000000, > 1000000); > @@ -966,7 +968,10 @@ static int mipi_csis_probe(struct platform_device *pdev) > return ret; > } > > - mipi_csis_phy_init(state); > + ret = mipi_csis_phy_init(state); > + if (ret < 0) > + return ret; > + > mipi_csis_phy_reset(state); > > mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D69FA3730 for ; Thu, 17 Oct 2019 09:46:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 312D921835 for ; Thu, 17 Oct 2019 09:46:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jvQtllqf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WuaWhX4a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 312D921835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=28eaP52BQ9G5czyQCNyztSFbirjyNZLwv+qub7H3fGs=; b=jvQtllqfTQS7XkHRJ0SxQatsIO eUtPD7ZenyWJXWig7oikk/c/+AP3TErgJFbkzixBrWCDCcswjaixxtmXYIXcAc095WOBzDSIjZSpt 6w+rcIfuy/fCZwGA/IGghqHILy42KTiNCVhlp9vdc/7qLQsshQ4vnBegVaaki0F8m9EiFK+A7ngS2 gyyn5U3AjGZtRgkxNqO1S9SNOzdcnknalDU3LZZpqqoOzSftLNYnPbq2Atb5x1OQzXo4hfTRJgxVJ ajPa71vq9TD3Sm3KFy2ytfErXz7clNmziuWY9T2eK7SrWUZS+muOfAReviu3Th/m2+3cNFAfVL2g7 /zdSFKGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iL2Mn-0004rD-Ha; Thu, 17 Oct 2019 09:46:45 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iL2Ml-0004qf-Aj for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2019 09:46:44 +0000 Received: by mail-wr1-x442.google.com with SMTP id b9so1577701wrs.0 for ; Thu, 17 Oct 2019 02:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=HKy0scgKD2Yqtf85mglqediv2brLo+GCB1Q93X6euAo=; b=WuaWhX4a2YttbDW1uaoNrQa8MGElT2XHF+EH1vrh+FhKdJ7zerR1iOBaQLR9V4And+ erCM0k4fsG6I7tXe/gPaplriKFpi/DpIms4+UWhyO2pqsec85FYZ7IV8Q/U9D7EZSpEd t0jAjzctzu/mzoif0XszF32ycjQ0+Nx0WpFXKbaDOIfwcWtyPV0ercNjE40OrDdqKyk0 pnOkfP29TCzKCCAo+9GQwF15UJ+hZ02YJ3UgvX/Rt8LB6aK+PeYivQUHZDhlHDY/eidf 82uy2VQ8ZWMCPe2sNLnAlOBcYmCOk8DP9tForqbHLWTLfhZVKYG7+m4Jsu5aiHRmkO7Y qOyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=HKy0scgKD2Yqtf85mglqediv2brLo+GCB1Q93X6euAo=; b=gtK72svjqFfT5MqezsEhw9TDDFGIf6D81R6vZCkHkKcUu8KNypTs3daGVLd5heeqKa qiBsr4Il+/tFWr4A3r4yEN/apI6o4ZnQBDlBxZv1aV4d29Anu+HPqQhyb6jnANv1c1VS 6Wb26hgwrUJOWv/f4RSR0LcURZipIEBv8U1SzKtxMnmXt+g6yvfLZrB+8o2QAGcpxU8U vJQ4D4uLnqt0fFMTBXFv5viD0LAPlqbz+kixXFfvPCupjKCOPB4wQPqGMzdxnZC5MfUW OdS/9nvk3E+PvdyGjbTHP9l/CwVKR9UVUzjMgCs9gAlPaa7Mh/MftNronBHCjdhO0VIs 1SGw== X-Gm-Message-State: APjAAAXadiLmAysN/Mo9/cMRPK3GH88dGfzjuSgFy/JWFJ4jHEcnxkfA RVumv6o7KSIcewZVEz67HlF0jj3mwz0= X-Google-Smtp-Source: APXvYqxrXHe+FRRJ2WwWs57//iOV5M+rIWiIDpk9WzExeUemaBkFY9x6xk6p7+jfLAgGOzcY00CGjQ== X-Received: by 2002:adf:f547:: with SMTP id j7mr2346059wrp.26.1571305601811; Thu, 17 Oct 2019 02:46:41 -0700 (PDT) Received: from arch-late (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id w17sm1678983wra.34.2019.10.17.02.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 02:46:41 -0700 (PDT) References: <20191015135915.6530-1-hslester96@gmail.com> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Rui Miguel Silva To: Chuhong Yuan Subject: Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get In-reply-to: <20191015135915.6530-1-hslester96@gmail.com> Date: Thu, 17 Oct 2019 10:46:38 +0100 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191017_024643_392931_95BBF0E7 X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Fabio Estevam , Pengutronix Kernel Team , Greg Kroah-Hartman , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Philipp Zabel , Steve Longerbeam , Mauro Carvalho Chehab , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chuhong, many thanks for the patch. On Tue 15 Oct 2019 at 14:59, Chuhong Yuan wrote: > devm_regulator_get may return an error but mipi_csis_phy_init misses > a check for it. > This may lead to problems when regulator_set_voltage uses the unchecked > pointer. > This patch adds a check for devm_regulator_get to avoid potential risk. > > Signed-off-by: Chuhong Yuan Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- > Changes in v2: > - Add a check in mipi_csis_probe for the modified mipi_csis_phy_init. > > drivers/staging/media/imx/imx7-mipi-csis.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 73d8354e618c..e8a6acaa969e 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -350,6 +350,8 @@ static void mipi_csis_sw_reset(struct csi_state *state) > static int mipi_csis_phy_init(struct csi_state *state) > { > state->mipi_phy_regulator = devm_regulator_get(state->dev, "phy"); > + if (IS_ERR(state->mipi_phy_regulator)) > + return PTR_ERR(state->mipi_phy_regulator); > > return regulator_set_voltage(state->mipi_phy_regulator, 1000000, > 1000000); > @@ -966,7 +968,10 @@ static int mipi_csis_probe(struct platform_device *pdev) > return ret; > } > > - mipi_csis_phy_init(state); > + ret = mipi_csis_phy_init(state); > + if (ret < 0) > + return ret; > + > mipi_csis_phy_reset(state); > > mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel