From: khalasa@piap.pl (Krzysztof Hałasa)
To: Andrey Utkin <andrey.utkin@corp.bluecherry.net>
Cc: mchehab@kernel.org, stable@vger.kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
maintainers@bluecherrydvr.com, andrey_utkin@fastmail.com,
ismael@iodev.co.uk, hverkuil@xs4all.nl, hans.verkuil@cisco.com
Subject: Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write
Date: Mon, 24 Oct 2016 06:57:25 +0200 [thread overview]
Message-ID: <m3zilu4a4q.fsf@t19.piap.pl> (raw)
In-Reply-To: <20161022153436.12076-1-andrey.utkin@corp.bluecherry.net> (Andrey Utkin's message of "Sat, 22 Oct 2016 16:34:36 +0100")
Andrey Utkin <andrey.utkin@corp.bluecherry.net> writes:
> --- a/drivers/media/pci/solo6x10/solo6x10.h
> +++ b/drivers/media/pci/solo6x10/solo6x10.h
> @@ -284,7 +284,10 @@ static inline u32 solo_reg_read(struct solo_dev *solo_dev, int reg)
> static inline void solo_reg_write(struct solo_dev *solo_dev, int reg,
> u32 data)
> {
> + u16 val;
> +
> writel(data, solo_dev->reg_base + reg);
> + pci_read_config_word(solo_dev->pdev, PCI_STATUS, &val);
> }
>
> static inline void solo_irq_on(struct solo_dev *dev, u32 mask)
This is ok for now. I hope I will find some to refine this, so not all
register writes are done with the penalty - eventually.
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2016-10-24 4:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 15:34 [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write Andrey Utkin
2016-10-24 4:57 ` Krzysztof Hałasa [this message]
2016-10-24 7:17 ` Andrey Utkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zilu4a4q.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=andrey_utkin@fastmail.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=ismael@iodev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.