From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NwzhJ-00028J-TQ
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 11:19:14 -0400
Received: from [140.186.70.92] (port=35905 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NwzhI-00027U-K1
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 11:19:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1NwzhH-0002ZQ-81
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 11:19:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7471)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1NwzhG-0002Z7-Ve
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 11:19:11 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2VFJ99g010984
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 31 Mar 2010 11:19:10 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <m3wrwso7c1.fsf@blackfin.pond.sub.org> (Markus Armbruster's
	message of "Wed, 31 Mar 2010 17:10:22 +0200")
References: <cover.1269373411.git.shaharh@redhat.com>
	<24a0619c9d6c07c5b10f5aff19478ff3040c4af8.1269373411.git.shaharh@redhat.com>
	<m3mxxv2ymx.fsf@blackfin.pond.sub.org>
	<20100326184030.GA25061@redhat.com>
	<m3wrwso7c1.fsf@blackfin.pond.sub.org>
Date: Wed, 31 Mar 2010 17:19:07 +0200
Message-ID: <m3zl1o1puc.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set'
	and 'info keybaord'
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Shahar Havivi <shaharh@redhat.com>, qemu-devel@nongnu.org

Markus Armbruster <armbru@redhat.com> wrote:
> Shahar Havivi <shaharh@redhat.com> writes:
>
>> On Fri, Mar 26, 2010 at 10:57:58AM +0100, Markus Armbruster wrote:
> [...]
>>> Since the index is not a stable identifier of keyboards, and we support
>>> multiple monitors, you're prone to remove the wrong keyboard.
>>> 
>>>     Monitor#1                           Monitor#2
>>>     "info keyboard" to find the index
>>>                                         unplug a keyboard, invalidating
>>>                                         index
>>>     keyboard_set <index>
>>> 
>>> I think it's best to use a stable ID, like we do in other places.  We
>>> commonly let the user specify it, e.g. as id=ID in -netdev, -device and
>>> elswhere.
>> What do we do when user not specify id for device?
>
> Two obvious options: make one up (problem: clashes), or stipulate "if
> you want to keyboard_set this keyboard, you must specify an id for it".

Second one is simpler, so .....

O:-)

Later, Juan.